horizon: 20190716 -> 1.0.0 by Luz · Pull Request #56497 · NixOS/nixpkgs

Luz · 2019-02-28T00:14:54Z

Motivation for this change

Things done

joachifm · 2019-03-23T06:09:50Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+		sha256 = "0qxw3vsbf9cg6b3pp3z1k2fjl8xrnjdr2gcncnr5jzd1mix6yd4y";
+	};
+
+	# Version in specific format, created by: "git log -1 --pretty="format:%h %ci %s"


Updating this by hand seems like it'd get annoying after a while. What about just taking part of src.rev or does it have to have that format? Or at least use git within the build to produce the thing.

Also note that overriding patchPhase prevents users from passing additional patches via patches; not necessarily a problem, but something to be aware of.

joachifm · 2019-03-23T06:10:34Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+		echo "const char *gitversion = \"810fc8d 2019-02-27 00:05:27 +0100 fix some includes\";" > src/gitversion.cpp
+	'';
+
+	buildInputs = [ pkgconfig sqlite libyamlcpp libuuid gnome3.gtkmm epoxy librsvg zeromq cppzmq glm libgit2 curl boost python3 opencascade ];


I think pkgconfig makes more sense as a native build input

joachifm · 2019-03-23T06:11:21Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+	NIX_CFLAGS_COMPILE = "-I${opencascade}/include/oce";
+
+	installPhase = ''
+		mkdir -p $out/bin


Golfing: I believe this reduces to install -Dt $out/bin horizon-{eda,imp}

We now have an install target that also installs icons, desktop entry and such.

joachifm · 2019-03-23T06:12:22Z

@GrahamcOfBorg build horizon-eda

aanderse

I have left a few comments I hope you will find helpful.

aanderse · 2019-08-05T02:07:29Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+{ stdenv, fetchFromGitHub, pkgconfig, sqlite, libyamlcpp, libuuid, gnome3, epoxy, librsvg, zeromq, cppzmq, glm, libgit2, curl, boost, python3, opencascade, libzip, podofo, wrapGAppsHook }:
+
+stdenv.mkDerivation rec {
+	name = "horizon-eda-${version}";


Please use pname = "horizon-eda"; instead as name = "${pname}-${version}"; is already implied.

aanderse · 2019-08-05T02:08:17Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+
+stdenv.mkDerivation rec {
+	name = "horizon-eda-${version}";
+	version = "20190716";


If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

aanderse · 2019-08-05T02:08:46Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+		echo "const char *gitversion = \"${src.rev}\";" > src/gitversion.cpp
+	'';
+
+	buildInputs = [ pkgconfig sqlite libyamlcpp libuuid gnome3.gtkmm epoxy librsvg zeromq cppzmq glm libgit2 curl boost python3 libzip podofo opencascade ];


Please see comment by @joachifm about pkgconfig belonging to nativeBuildInputs instead.

aanderse · 2019-08-05T02:10:02Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+
+	meta = with stdenv.lib; {
+		description = "A free EDA software to develop printed circuit boards";
+		homepage = https://github.com/carrotIndustries/horizon;


Please quote.

aanderse · 2019-08-05T02:10:46Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+	'';
+
+	preFixup = ''
+		wrapProgram "$out/bin/horizon-eda" "''${gappsWrapperArgs[@]}"


Is this actually required?

aanderse · 2020-02-08T14:44:52Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+	src = fetchFromGitHub {
+		owner = "horizon-eda";
+		repo = "horizon";
+		rev = "3f777bd2501b953981d64cf2054c265ce8d65c02";


Suggested change

rev = "3f777bd2501b953981d64cf2054c265ce8d65c02";

rev = "v${version}";

aanderse · 2020-02-08T14:47:17Z

pkgs/applications/science/electronics/horizon-eda/default.nix

+		sha256 = "1d40lfgylwl3srqazyjgw9l3n7i82xrvkjcxvpx7ddyzy1d2aqmr";
+	};
+
+	buildInputs = [ sqlite libyamlcpp libuuid gnome3.gtkmm epoxy librsvg zeromq cppzmq glm libgit2 curl boost python3 libzip podofo opencascade ];


I would prefer if you were to sort this alphabetically (easier for me to do a quick comparison against https://docs.horizon-eda.org/en/latest/build-linux.html), but more importantly place each entry on a new line, like so:

buildInputs = [ boost curl ... zeromq ];

@Luz

Mostly based on NixOS#56497 by @Luz

stale · 2020-08-13T23:55:08Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

guserav · 2021-01-30T17:36:58Z

As of #99964 this is merged so this shouldn't be necessary any longer

horozon-eda-unstable: init at 2019-02-27

6b812dc

Luz mentioned this pull request Feb 28, 2019

Building on Linux horizon-eda/horizon#218

Closed

joachifm reviewed Mar 23, 2019

View reviewed changes

merge

3cba716

Luz closed this Jul 16, 2019

Luz deleted the horizon-eda branch July 16, 2019 18:59

Luz restored the horizon-eda branch July 16, 2019 19:05

horizon-eda: 2019-02-27 -> 2019-07-16

0d233fa

Luz reopened this Jul 16, 2019

aanderse requested changes Aug 5, 2019

View reviewed changes

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 5, 2020

horizon: 20190716 -> 1.0.0

3107ec7

Luz force-pushed the horizon-eda branch from 0cd2175 to 3107ec7 Compare February 5, 2020 23:14

Luz changed the title ~~horizon-eda-unstable: init at 2019-02-27~~ horizon: 20190716 -> 1.0.0 Feb 6, 2020

merge

d3ce203

Luz requested a review from aanderse February 6, 2020 21:48

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 6, 2020

aanderse requested changes Feb 8, 2020

View reviewed changes

yrashk mentioned this pull request May 4, 2020

horizon-eda: init at 1.1.1 #86694

Closed

10 tasks

yrashk added a commit to yrashk/nixpkgs that referenced this pull request May 13, 2020

horizon-eda: init at 1.1.1

50c7b77

Mostly based on NixOS#56497 by @Luz

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2020

ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020

ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020

ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020

guserav closed this Jan 30, 2021

Luz deleted the horizon-eda branch May 7, 2023 18:33

	rev = "3f777bd2501b953981d64cf2054c265ce8d65c02";
	rev = "v${version}";

Uh oh!

Conversation

Luz commented Feb 28, 2019

Motivation for this change

Things done

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joachifm commented Mar 23, 2019

Uh oh!

aanderse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Aug 13, 2020

Uh oh!

guserav commented Jan 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants