Skip to content

gmrender-resurrect: Make build against libupnp 1.14 ok#99899

Merged
timokau merged 1 commit intoNixOS:masterfrom
ardumont:bump-gmrender-resurrect
Oct 7, 2020
Merged

gmrender-resurrect: Make build against libupnp 1.14 ok#99899
timokau merged 1 commit intoNixOS:masterfrom
ardumont:bump-gmrender-resurrect

Conversation

@ardumont
Copy link
Contributor

@ardumont ardumont commented Oct 6, 2020

Related to #93048

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: debian with nix
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nixpkgs-review pr 99899 [2]
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size: -1136 [1]
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1]

before /nix/store/vmr8ny2pwaa6jdnrq14yml0b58cbs0xi-gmrender-resurrect-0.0.8      813998272
after  /nix/store/m8vmfyly18zx3wzx881fmhx7v2wkvqgc-gmrender-resurrect-0.0.8      813999408

[2]

$ nixpkgs-review pr 99899
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/99899/head:refs/nixpkgs-review/1
remote: Enumerating objects: 59, done.
remote: Counting objects: 100% (59/59), done.
remote: Total 101 (delta 59), reused 59 (delta 59), pack-reused 42
Receiving objects: 100% (101/101), 190.48 KiB | 241.00 KiB/s, done.
Resolving deltas: 100% (72/72), completed with 50 local objects.
From https://github.com/NixOS/nixpkgs
   0093e4e6a99..9ae60c87474  master               -> refs/nixpkgs-review/0
 + 024ad57ed18...98e5369bafa refs/pull/99899/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/tony/.cache/nixpkgs-review/pr-99899/nixpkgs 9ae60c874749f2bdbfb1ffb1249621f050410ad7
Preparing worktree (detached HEAD 9ae60c87474)
Updating files: 100% (22850/22850), done.
HEAD is now at 9ae60c87474 act: build with go 1.15 on darwin
$ git merge --no-commit 98e5369bafacf919982813d86e5dc99095d5d3d0
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/tony/.cache/nixpkgs-review/pr-99899/build.nix
building '/nix/store/97ijw7dfydq4npnv8hc6b13fdvm72hl4-env.drv'...
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/99899
1 package built:
gmrender-resurrect

$ nix-shell /home/tony/.cache/nixpkgs-review/pr-99899/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-99899]$ exit
$ git worktree prune

@ardumont ardumont mentioned this pull request Oct 6, 2020
10 tasks
@ofborg ofborg bot requested a review from ashkitten October 6, 2020 20:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 6, 2020
@ardumont ardumont force-pushed the bump-gmrender-resurrect branch from 7c21c79 to 98e5369 Compare October 6, 2020 21:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 6, 2020
@ashkitten
Copy link
Contributor

not actively using this rn so can't test but if it works then lgtm

@timokau timokau merged commit b3af4a4 into NixOS:master Oct 7, 2020
@ardumont ardumont deleted the bump-gmrender-resurrect branch October 7, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants