Drop UpnpInit#214
Merged
Merged
Conversation
Contributor
|
How far back is UpnpInit2 available? I think there are a number of users who still build against libupnp 1.6. |
Contributor
Author
|
UpnpInit2 is available since version 1.6.7 and pupnp/pupnp@2bcbdff but more importantly without this change (and the use of pupnp version 1.14.x), users are not protected against CallStranger which has a High CVE score: https://nvd.nist.gov/vuln/detail/CVE-2020-12695. |
hzeller
requested changes
Aug 21, 2020
Owner
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
Thanks for fixing the CVE vulnerability.
The change of the ip-address flag name is missing in the manpage. Other than that, LGTM.
UpnpInit has been dropped from libupnp 1.14.x as it can't be fixed against CallStranger a.k.a. CVE-2020-12695 so replace it by UpnpInit2 which is available since version 1.6.7 and pupnp/pupnp@2bcbdff Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
10 tasks
ardumont
added a commit
to ardumont/nixpkgs
that referenced
this pull request
Oct 6, 2020
Current PR opened but not merged upstream [1] [1] hzeller/gmrender-resurrect#214
|
Can we get this merged? Most distros are dropping libupnp <0.14.0 |
hzeller
added a commit
that referenced
this pull request
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpnpInit has been dropped from libupnp 1.14.x as it can't be fixed against CallStranger a.k.a. CVE-2020-12695 so replace it by UpnpInit2 which is available since version 1.6.7 and pupnp/pupnp@2bcbdff
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com