nixos: hardware.nvidia.package option for selecting nvidia package#99323
Merged
veprbl merged 1 commit intoNixOS:masterfrom Jan 31, 2021
Merged
nixos: hardware.nvidia.package option for selecting nvidia package#99323veprbl merged 1 commit intoNixOS:masterfrom
veprbl merged 1 commit intoNixOS:masterfrom
Conversation
d50497a to
123f8b1
Compare
123f8b1 to
ba88f04
Compare
10 tasks
ba88f04 to
3cb94f1
Compare
10 tasks
3cb94f1 to
a1f6e80
Compare
Make it possible to select a derivation to use. This also moves some logic that belongs to the derivation back into it.
a1f6e80 to
450cb04
Compare
Contributor
|
I think this should be accompanied with documentation of what the end-user needs to change. For instance, if the user has something like:
Meaning, the driver is not simply "nvidia", then it needs to be changed to "nvidia" and then the following needs to be added:
Of course the documentation should be written more elegantly, but that's the gist of it. |
9 tasks
Member
|
Don't forget to update the manual: nixpkgs/nixos/doc/manual/configuration/x-windows.xml Lines 147 to 153 in a0b7bd6 And the example for |
12 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to select a derivation to use. This also moves some
logic that belongs to the derivation back into it.
Motivation for this change
#49703 upkeep
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)