nixos/nvidia: clean up and add dynamic boost

[Gerg-L]

Description of changes

Closes: #211300
The NVIDIA module was in need of some TLC so I cleaned it up and re-formatted.

the only actual change in the first commit should be the removal of the isDeprecated = str: (hasPrefix "nvidia" str) && (str != "nvidia"); check from: #99323
(2 years old)
and the nvidia prime rename from: #66601
(4 years old)

The second commit is the addition of NVIDIA Dynamic Boost from #211300

Some more testing would be appreciated

Questions: should I be using lib.mdDoc and lib.options.mkPackageOptionMD here or not?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[jian-lin]

Questions: should I be using lib.mdDoc and lib.options.mkPackageOptionMD here or not?

I think you should use the MD variants because it makes backporting changes to the stable much easier and has no harm.

[Gerg-L]

I think you should use the MD variants because it makes backporting changes to the stable much easier and has no harm.

Alright, done.

[cch000]

Any updates?

[Kiskae]

Other than the required version it looks good to me, although going through this has made me realize the nvidia package itself probably needs a rewrite at some point.

[Gerg-L]

Other than the required version it looks good to me, although going through this has made me realize the nvidia package itself probably needs a rewrite at some point.

Most definitely, I was thinking of rewriting all of services.xserver and all the Wayland compositor modules.

I'm trying to get to it before 22.11 is released

[fpletz]

I'm trying to get to it before 22.11 is released

Please send me a copy of the time machine you're using. As mine has been in the shop for aeons I'm not able to fix the bad code I wrote for 17.09. 😆

[Gerg-L]

I'm trying to get to it before 22.11 is released

Please send me a copy of the time machine you're using. As mine has been in the shop for aeons I'm not able to fix the bad code I wrote for 17.09. 😆

Fat fingers lol, meant 23.11