Skip to content

pythonPackages.protobuf: fix cross-compilation#99141

Merged
FRidh merged 1 commit intoNixOS:masterfrom
lopsided98:protobuf-cross
Oct 25, 2020
Merged

pythonPackages.protobuf: fix cross-compilation#99141
FRidh merged 1 commit intoNixOS:masterfrom
lopsided98:protobuf-cross

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Sep 30, 2020

Motivation for this change

Fixes cross-compilation of the protobuf Python library. This may need #98915 to actually successfully cross-compile (I haven't tested it without it), but I don't think that needs to block merging this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Ericson2314 @jonringer @dotlambda @delroth

@lopsided98
Copy link
Contributor Author

lopsided98 commented Sep 30, 2020

This may fail:

@ofborg build pkgsCross.armv7l-hf-multiplatform.python3Packages.protobuf

@lopsided98
Copy link
Contributor Author

lopsided98 commented Sep 30, 2020

@ofborg build pkgsCross.aarch64-multiplatform.python3Packages.protobuf

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Sep 30, 2020
@FRidh FRidh merged commit 50277eb into NixOS:master Oct 25, 2020
@lopsided98 lopsided98 deleted the protobuf-cross branch October 25, 2020 17:24
@knedlsepp knedlsepp mentioned this pull request Nov 22, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

1 more reviewer

@FRidh FRidh FRidh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lopsided98 @FRidh