python.pkgs.protobuf: Fix cpp backend#147016
Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom Dec 16, 2021
Merged
Conversation
github-actions
bot
added
the
6.topic: python
knedlsepp
changed the title
Member
Author
knedlsepp
changed the title
Member
|
@GrahamcOfBorg eval |
ofborg
bot
added
10.rebuild-darwin: 101-500
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
|
@GrahamcOfBorg build python38Packages.protobuf python39Packages.protobuf |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
knedlsepp
force-pushed
the
python-protobuf-cpp-backend
branch
from
eeb4f3c to
fcbe3f1
Compare
Member
Author
|
@SuperSandro2000 Sorry for the delay. I resolved the remaining comments. |
ofborg
bot
added
the
11.by: package-maintainer
Member
|
@GrahamcOfBorg build python38Packages.protobuf python39Packages.protobuf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes the python-protobuf C++ backend which is way faster than the python backend.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes