Skip to content

ghc8102Binary integer simple fix#98859

Merged
jonringer merged 2 commits intoNixOS:masterfrom
sorki:hask/ghc8102Binary_integer_fix
Sep 26, 2020
Merged

ghc8102Binary integer simple fix#98859
jonringer merged 2 commits intoNixOS:masterfrom
sorki:hask/ghc8102Binary_integer_fix

Conversation

@sorki
Copy link
Member

@sorki sorki commented Sep 26, 2020

Motivation for this change

Follow-up to #98808. CC @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sorki sorki requested a review from cdepillabout as a code owner September 26, 2020 12:38
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 26, 2020
@jonringer
Copy link
Contributor

jonringer commented Sep 26, 2020 •
edited
Loading

I saw this as well, and I think it was the intention of the original author.

EDIT: I chose not to, because I wasn't sure if there was other inputs

jonringer
jonringer approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98859 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sorki @jonringer