haskell.ghc8102Binary: fix extra inputs, fix ofborg eval#98808
Merged
jonringer merged 1 commit intoNixOS:masterfrom Sep 25, 2020
Merged
haskell.ghc8102Binary: fix extra inputs, fix ofborg eval#98808jonringer merged 1 commit intoNixOS:masterfrom
jonringer merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
ofborg now passes locally: |
Contributor
Author
|
probably going to merge this as soon as |
Contributor
Author
|
Member
|
Thanks for the quick fix for this @jonringer. It looks like @doronbehar caught this in #98656 (comment), and it may have been introduced by @sorki. |
Member
|
Thanks, I'll submit a fix adding it to |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fix ofborg
just allow for expression to receive more than necessary inputs
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)