Skip to content

haskell.ghc8102Binary: fix extra inputs, fix ofborg eval#98808

Merged
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:fix-ofborg-haskell
Sep 25, 2020
Merged

haskell.ghc8102Binary: fix extra inputs, fix ofborg eval#98808
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:fix-ofborg-haskell

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 25, 2020

Motivation for this change

fix ofborg

nix-env failed:
warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/.gc-of-borg-outpaths.nix:44:12, called from undefined position:
while evaluating 'g' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/attrsets.nix:276:19, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/release-lib.nix:144:38, called from undefined position:
while evaluating 'isDerivation' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/attrsets.nix:305:18, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/release-lib.nix:146:10:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/haskell-packages.nix:115:8, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/attrsets.nix:292:43:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:77:32, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/haskell-packages.nix:115:14:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:77:41:
anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/development/compilers/ghc/8.10.2-binary.nix:1:1 called with unexpected argument 'enableIntegerSimple', at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:69:16

just allow for expression to receive more than necessary inputs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

ofborg now passes locally:

[15:14:22] jon@nixos ~/projects/nixpkgs (master)
$ GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths
[15:17:09] jon@nixos ~/projects/nixpkgs (master)

@jonringer
Copy link
Contributor Author

probably going to merge this as soon as nixpkgs-review finishes. as this is breaking eval on all PRs

@jonringer
Copy link
Contributor Author

$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-98808/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/98808
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-98808/shell.nix

@cdepillabout
Copy link
Member

Thanks for the quick fix for this @jonringer.

It looks like @doronbehar caught this in #98656 (comment), and it may have been introduced by @sorki.

@sorki
Copy link
Member

sorki commented Sep 26, 2020

Thanks, I'll submit a fix adding it to integerSimpleExcludes (https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/haskell-packages.nix#L5) later, I want to try fixing aarch64 build as well.

@sorki sorki mentioned this pull request Sep 26, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants