Skip to content

doc: nodejs: Update override example to use overlays#96963

Merged
rnhmjoj merged 1 commit intoNixOS:masterfrom
doronbehar:doc/nodejs
Sep 4, 2020
Merged

doc: nodejs: Update override example to use overlays#96963
rnhmjoj merged 1 commit intoNixOS:masterfrom
doronbehar:doc/nodejs

Conversation

@doronbehar
Copy link
Contributor

Also: Add links so it'll be easier to find the referred files.

Motivation for this change

It took me at least 15 minutes to understand what to do for #96961 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also: Add links so it'll be easier to find the referred files.
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2020
@rnhmjoj rnhmjoj merged commit 2b575c5 into NixOS:master Sep 4, 2020
@doronbehar doronbehar deleted the doc/nodejs branch March 2, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants