Skip to content

balena-cli: init at <Updating>#96961

Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/nodePackages/balena-cli
Closed

balena-cli: init at <Updating>#96961
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/nodePackages/balena-cli

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 2, 2020

Motivation for this change

Add balena-cli - a CLI tool to manage balena's devices and apps.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2020
@doronbehar doronbehar changed the title nodePackages.balena-cli: init at 12.14.18 nodePackages.balena-cli: init at <Updating> Sep 6, 2020
@doronbehar doronbehar force-pushed the pkg/nodePackages/balena-cli branch from 22fb401 to 33c425b Compare September 6, 2020 08:39
@doronbehar
Copy link
Contributor Author

Apparently, their updates are rather frequent, so this package should have it's own ./generate.sh script that will do it all, only for this package. This will reduce the probable merge conflicts of updating it among too many other node packages. I'm converting to draft as the current, newer build fails with:

npm ERR! syscall chmod
npm ERR! path /nix/store/2m8cziwx735scqdqs81081z4dwxyxzqi-node_balena-cli-12.14.18/lib/node_modules/balena-cli/bin/balena
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/nix/store/2m8cziwx735scqdqs81081z4dwxyxzqi-node_balena-cli-12.14.18/lib/node_modules/balena-cli/bin/balena'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2020-09-06T08_41_48_435Z-debug.log

@doronbehar doronbehar marked this pull request as draft September 6, 2020 08:46
@doronbehar doronbehar changed the title nodePackages.balena-cli: init at <Updating> balena-cli: init at <Updating> Sep 6, 2020
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 6, 2020
@doronbehar doronbehar force-pushed the pkg/nodePackages/balena-cli branch from 33c425b to d83b7d0 Compare September 9, 2020 10:05
@doronbehar doronbehar marked this pull request as ready for review September 9, 2020 10:05
@doronbehar
Copy link
Contributor Author

Now it's working.

@doronbehar
Copy link
Contributor Author

DAMN, so many people got subscribed. Sorry. Now I used cherry-pick instead of rebase and I hope it's fine.

@ofborg ofborg bot removed 6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: vim Advanced text editor 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 11, 2020
@doronbehar doronbehar force-pushed the pkg/nodePackages/balena-cli branch 2 times, most recently from f4671ed to 07c8f9a Compare September 21, 2020 15:56
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to just update the global node packages, instead of having a 12k application-specific deps file?

@doronbehar
Copy link
Contributor Author

is there a way to just update the global node packages, instead of having a 12k application-specific deps file?

484K* 😆 :

$ du -csh pkgs/development/tools/balena-cli
484K

It is possible, but their releases are so frequent, so I'm not sure how to handle this - putting it in the general nodePackages set would mean the updates it'll receive will be very infrequent. OTH, I'm not installing this tool imperatively via npm -g install because it is compiled.

Maybe we should improve the nodePackages ecosystem so it wouldn't be that hard to get changes into Nixpkgs. IDK.

@jonringer
Copy link
Contributor

I think in a year-or-two, we might just be using flakes for applications like this. So that nixpkgs is small and stable. And then just opt-in to flakes that have large dependency sets.

@zowoq zowoq removed their request for review September 23, 2020 01:01
@doronbehar doronbehar force-pushed the pkg/nodePackages/balena-cli branch from 07c8f9a to 59247c6 Compare October 1, 2020 17:07
@doronbehar doronbehar force-pushed the pkg/nodePackages/balena-cli branch from 59247c6 to 79554e1 Compare October 21, 2020 17:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-nodepackages-maintainers/9176/27

@doronbehar doronbehar mentioned this pull request Dec 5, 2020
10 tasks
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@doronbehar
Copy link
Contributor Author

I'll close this as it seems not suitable for nixpkgs with their release model and our nodejs system. In the future this project will be available using the flake https://gitlab.com/doronbehar/nixNodeJSPkgs .

@doronbehar doronbehar closed this Jun 4, 2021
@doronbehar doronbehar deleted the pkg/nodePackages/balena-cli branch March 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants