firefox: increase build timeout#96767
Merged
1 commit merged intomasterfrom Sep 9, 2020
unknown repository
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
sugar700
added a commit
to sugar700/nixpkgs
that referenced
this pull request
Oct 30, 2020
This matches a similar change made to Firefox in NixOS#96767. A lot of code is shared between Firefox and Thunderbird so it makes sense to increase timeouts for Thunderbird as well.
10 tasks
Member
|
Wait... the link you referenced had a last attempt years ago. How is that relevant now? Besides, I hear that the (current) default is 10h so it's actually a decrease. |
Author
|
Its not relevant, I'm just not able to navigate hydra effectively :\ |
roberth
added a commit
that referenced
this pull request
Nov 11, 2020
The default timeout is 10h on Hydra currently, so this timeout setting is pointless or counterproductive. This commit seems to have been made in error #96767 (comment) This reverts commit 1733d51.
roberth
added a commit
that referenced
this pull request
Nov 11, 2020
The default timeout is 10h on Hydra currently, so this timeout setting is pointless or counterproductive. This commit seems to have been made in error #96767 (comment) This reverts commit c57fedb.
10 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Firefox aarch64 builds are timing-out: https://hydra.nixos.org/job/nixos/unstable-aarch64/nixpkgs.firefox-unwrapped.aarch64-linux
Things done
Increase
meta.timeout.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)