Skip to content

Revert "firefox: set build timeout at eight hours"#103474

Merged
vcunat merged 1 commit intomasterfrom
revert-96767
Nov 14, 2020
Merged

Revert "firefox: set build timeout at eight hours"#103474
vcunat merged 1 commit intomasterfrom
revert-96767

Conversation

@roberth
Copy link
Member

@roberth roberth commented Nov 11, 2020

Motivation for this change

Keep things tidy.

The default timeout is 10h on Hydra currently, so this timeout
setting is pointless or counterproductive.
This commit seems to have been made in error
#96767 (comment)

This reverts commit c57fedb.

Will merge when ofborg succeeds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The default timeout is 10h on Hydra currently, so this timeout
setting is pointless or counterproductive.
This commit seems to have been made in error
#96767 (comment)

This reverts commit c57fedb.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 11, 2020
@vcunat vcunat merged commit 739b762 into master Nov 14, 2020
@vcunat vcunat deleted the revert-96767 branch November 14, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants