x265: dont build high bit-depths for 32bit systems#96260
Merged
orivej-nixos merged 1 commit intoNixOS:masterfrom Aug 31, 2020
Merged
x265: dont build high bit-depths for 32bit systems#96260orivej-nixos merged 1 commit intoNixOS:masterfrom
orivej-nixos merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
Result of 1 package failed to build:- airwave 8 packages built:- driversi686Linux.libvdpau-va-gl - javacard-devkit - pipelight - playonlinux - wine (wineFull) - wineStaging (wine-staging) - wineWowPackages.full - winetricks |
mat8913
approved these changes
Aug 29, 2020
Contributor
mat8913
left a comment
There was a problem hiding this comment.
Thanks. I needed this to build wine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #92052 the
x265.i686-linuxbuild is failing. The rewrite removed ais64bitcheck for the high bit depth flags, which fail to build on 32bit systems.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)CC @dominikh