Skip to content

Comments

x265: dont build high bit-depths for 32bit systems#96260

Merged
orivej-nixos merged 1 commit intoNixOS:masterfrom
B4dM4n:x265-32bit-build
Aug 31, 2020
Merged

x265: dont build high bit-depths for 32bit systems#96260
orivej-nixos merged 1 commit intoNixOS:masterfrom
B4dM4n:x265-32bit-build

Conversation

@B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Aug 25, 2020

Motivation for this change

Since #92052 the x265.i686-linux build is failing. The rewrite removed a is64bit check for the high bit depth flags, which fail to build on 32bit systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @dominikh

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Aug 25, 2020

Result of nixpkgs-review pr 96260 1

1 package failed to build:
- airwave
8 packages built:
- driversi686Linux.libvdpau-va-gl
- javacard-devkit
- pipelight
- playonlinux
- wine (wineFull)
- wineStaging (wine-staging)
- wineWowPackages.full
- winetricks

@ofborg ofborg bot requested a review from codyopel August 25, 2020 10:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 25, 2020
Copy link
Contributor

@mat8913 mat8913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I needed this to build wine.

@orivej-nixos orivej-nixos merged commit 8ef6f4b into NixOS:master Aug 31, 2020
@B4dM4n B4dM4n deleted the x265-32bit-build branch August 31, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants