x265: build a single shared library for all bit-depths#92052
Merged
FRidh merged 1 commit intoNixOS:stagingfrom Aug 15, 2020
Merged
x265: build a single shared library for all bit-depths#92052FRidh merged 1 commit intoNixOS:stagingfrom
FRidh merged 1 commit intoNixOS:stagingfrom
Conversation
This builds the 10-bit and 12-bit versions of x265 as static
libraries, which then get linked into the 8-bit dynamic library and
executable. This causes x265 to default to 8-bit, but make 10- and
12-bit available to callers that use introspection, such as ffmpeg.
$ x265 -V
x265 [info]: HEVC encoder version 3.2
x265 [info]: build info [Linux][GCC 9.3.0][64 bit] 8bit+10bit+12bit
x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2
$ ffmpeg -h encoder=libx265
[...]
Supported pixel formats: yuv420p yuvj420p yuv422p yuvj422p yuv444p yuvj444p gbrp yuv420p10le yuv422p10le yuv444p10le gbrp10le yuv420p12le yuv422p12le yuv444p12le gbrp12le gray gray10le gray12le
Inspired by @codyopel's comment on NixOS#80405.
Member
|
/marvin opt-in |
Member
|
For anyone reading, I'm running |
Member
|
I let it run for about 3 hours and it noted 28 package failures before starting compilation on really big packages like Blender. I don't think my desktop is beefy enough to run this whole workload: https://gist.github.com/mdlayher/7e4cc832f5cc0f2ec7e6934bd74a8c0f |
Member
|
I can confirm that this also works locally on my machine, but I'm out of my depth as far as diagnosing any possible reverse dependency issues: |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds the 10-bit and 12-bit versions of x265 as static
libraries, which then get linked into the 8-bit dynamic library and
executable. This causes x265 to default to 8-bit, but make 10- and
12-bit available to callers that use introspection, such as ffmpeg.
Inspired by @codyopel's comment on #80405.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)