nixos/fonts: remove fontconfig-penultimate#95681
Merged
infinisil merged 2 commits intoNixOS:masterfrom Aug 17, 2020
Merged
Conversation
This was referenced Aug 17, 2020
NickHu
approved these changes
Aug 17, 2020
jtojnar
approved these changes
Aug 17, 2020
Member
Author
|
@ttuegel any opinions? |
Member
|
Sounds very reasonable :) |
Contributor
|
Yep, I was planning to do this after we already removed fontconfig-ultimate. But I think we should add a mention in the release notes for 20.09. |
Member
|
In this case I don't think we need a release notes entry, because an explanatory error is already being thrown if people used it before. Imo release notes are only necessary for things we can't have nice warnings/errors for. |
evanjs
added a commit
to evanjs/nixos_cfg
that referenced
this pull request
Aug 19, 2020
penultimate has been removed see NixOS/nixpkgs#95681 for more information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fontconfig-penultimatewas a minimalistic fork of the abandonedfontconfig-ultimate. It also hasn't received any updates in the last 3 years. Withfontconfigbeing in much better shape these days, there's no need to keep it.#92571 (comment)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)