fonts.fontconfig-penultimate: remove dependency on fontconfig_210#95677
Closed
NickHu wants to merge 1 commit intoNixOS:masterfrom
Closed
fonts.fontconfig-penultimate: remove dependency on fontconfig_210#95677NickHu wants to merge 1 commit intoNixOS:masterfrom
NickHu wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
|
I wonder if we should keep penultimate at all: #92571 (comment) |
Member
|
I opened #95681 removing fontconfig-pentultimate. |
Contributor
Author
|
Ah, I didn't realise that upstream fontconfig-penultimate hasn't been updated in over 3 years. I guess what you propose makes more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #93562 was merged,
configurations which set
fonts.fontconfig.penultimate.enableto truewill fail to build, tripping the assertion:
This rectifies the module, deleting references to fontconfig_210. I just
did the most obvious thing possible to make it build, and didn't really
think properly about the consequences, so I would appreciate some review
on this one from someone who knows the fontconfig stuff a bit better.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)