Skip to content

qcsxcad: use libsForQt5 package scope for qt deps#95142

Merged
jonringer merged 1 commit intoNixOS:masterfrom
matthuszagh:qcsxcad
Aug 11, 2020
Merged

qcsxcad: use libsForQt5 package scope for qt deps#95142
jonringer merged 1 commit intoNixOS:masterfrom
matthuszagh:qcsxcad

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 11, 2020 •
edited
Loading

Motivation for this change

@jonringer this package had the same issue as the one you mentioned here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 11, 2020
jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95142 1

@matthuszagh matthuszagh deleted the qcsxcad branch August 11, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthuszagh @jonringer