Skip to content

appcsxcad: init at unstable-2020-01-04#95138

Merged
jonringer merged 1 commit intoNixOS:masterfrom
matthuszagh:appcsxcad
Aug 11, 2020
Merged

appcsxcad: init at unstable-2020-01-04#95138
jonringer merged 1 commit intoNixOS:masterfrom
matthuszagh:appcsxcad

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 11, 2020 •
edited
Loading

Motivation for this change

Next in this PR. @jonringer thanks!

appcsxcad

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 11, 2020
jonringer
jonringer reviewed Aug 11, 2020
View reviewed changes
@jonringer
Copy link
Contributor

jonringer commented Aug 11, 2020

also please remove the shell scrip which gets moved into bin, it's not properly wrapped

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-95138]$ tree ./results/appcsxcad/bin/
./results/appcsxcad/bin/
├── AppCSXCAD
└── AppCSXCAD.sh

@matthuszagh matthuszagh requested a review from jonringer August 11, 2020 05:56
@matthuszagh matthuszagh mentioned this pull request Aug 11, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95138 1

1 package built:
- appcsxcad

@matthuszagh matthuszagh deleted the appcsxcad branch August 11, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthuszagh @jonringer