Skip to content

vtk: enable qt gui support#94877

Closed
matthuszagh wants to merge 1 commit intoNixOS:masterfrom
matthuszagh:vtk
Closed

vtk: enable qt gui support#94877
matthuszagh wants to merge 1 commit intoNixOS:masterfrom
matthuszagh:vtk

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 7, 2020

Motivation for this change

Part of this PR. @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthuszagh matthuszagh requested a review from bcdarwin August 7, 2020 16:35
@ofborg ofborg bot requested a review from knedlsepp August 7, 2020 17:02
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 7, 2020
@bcdarwin
Copy link
Member

bcdarwin commented Aug 7, 2020

nixpkgs-review succeeds, but lib/libvtkGUISupportQt-8.2.so.1 is already present in the output of vtkWithQt5 on master (more generally the results of find result -name '*GUI*' are identical), so it seems like this option is already implied by VTK_Group_Qt in the current version of VTK?

@matthuszagh
Copy link
Contributor Author

@bcdarwin thanks for the review and it seems you're right. Thanks for spotting that. I had originally written this PR for an earlier version of the derivation that didn't provide the Qt GUI support. Closing this.

@matthuszagh matthuszagh closed this Aug 7, 2020
@matthuszagh matthuszagh deleted the vtk branch August 7, 2020 18:12
@bcdarwin
Copy link
Member

bcdarwin commented Aug 9, 2020

[Probably obviated by #84772.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants