Skip to content

vtkWithQt4: actually build QVTK libs/headers#84772

Merged
veprbl merged 1 commit intoNixOS:masterfrom
bcdarwin:fix-qvtk
Apr 29, 2020
Merged

vtkWithQt4: actually build QVTK libs/headers#84772
veprbl merged 1 commit intoNixOS:masterfrom
bcdarwin:fix-qvtk

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Apr 9, 2020

Motivation for this change
  • VTK_USE_QT is obsolete and didn't have the intended effect. (For instance, you may verify that QVTKWidgets.h is now present in the output, unlike previously.)

cc @knedlsepp @veprbl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from knedlsepp April 9, 2020 04:22
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 9, 2020
- VTK_USE_QT is obsolete and didn't have the intended effect
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/148

@veprbl
Copy link
Member

veprbl commented Apr 27, 2020

@GrahamcOfBorg build vtkWithQt4 vtkWithQt4.passthru.tests

@bcdarwin
Copy link
Member Author

bcdarwin commented Apr 28, 2020

The Darwin build hasn't run yet but Qt4 doesn't evaluate on Darwin anyway.

@veprbl veprbl merged commit 948b383 into NixOS:master Apr 29, 2020
@bcdarwin bcdarwin deleted the fix-qvtk branch April 29, 2020 23:12
@bcdarwin bcdarwin mentioned this pull request Aug 9, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants