gerbera: init at 1.6.1

[ardumont]

Initialize a new and maintained upnp media server (gerbera).
Next step is to open a service which allows to configure it declaratively.

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS (tested through my own overrides on odroid-n2 at [1] [2])
  • macOS
  • other Linux distributions: debian with nix
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after): +74906824 (new)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Note that it works but the compilation displays warnings because that depends on
other commits not yet merged:

• libupnp: 1.12.0 -> 1.14.0 #93048 (this one is duplicated in this very branch as it's required)
• pupnp: Open enableReuseAddr configure option #93099
• spdlog: 1.6.0 -> 1.7.0 #93098

[1] mypkgs override definition
https://github.com/ardumont/mypkgs/blob/master/default.nix#L10-L33

[2] my own (for now) gerbera configuration declaration for the gerbera service
https://gitlab.com/ardumont/nixos/-/blob/master/odroid/gerbera/default.nix

[aanderse]

Since #82429 appears to be abandoned this PR is very welcome 👍

[ardumont]

Since #82429 appears to be abandoned this PR is very welcome

Awesome (that it is welcome ;)

force-pushed...

I fixed the homepage which targeted the old mediatomb homepage.

[ardumont]

Heads up, started the work on the mediatomb/gerbera service whose current head is at [1]

@aanderse I started from the other diff and iterated over that work. I also
took into consideration your review from the other diff ;)

I don't actually know how to properly test it though, so far:

nix-build --expr "(import <nixpkgs> {}).callPackage ./nixos/modules/services/misc/mediatomb.nix { }"

(which did not complain).

I probably need to look into how to add proper nix tests.

Note that, as a user, I don't like the idea to have a service name mediatomb
which runs something named gerbera. Even though they share history (as a
maintainer I know this), i'd say that's not the user's concerns though ;)

I did not open a PR yet as I did not have any response from the other
maintainer (who started a similar work). Plus I'm going afk, it's the week-end
after all ;)

I still thought that was worth a heads up ;)

[1] ardumont@629e04c

Cheers,

[symphorien]

You can test with nix-build -A gerbera from the root of the repo.

[ardumont]

You can test with nix-build -A gerbera from the root of the repo.

Yes, thanks, i know (i did already).
I meant testing on the other started work for the mediatomb/gerbera service (which should be in another thread).
I think i'll drop by irc and ask there.

Cheers,

[ardumont]

I probably need to look into how to add proper nix tests.

I meant testing on the other started work for the mediatomb/gerbera service (which should be in another thread).
I think i'll drop by irc and ask there.

nice, found back [1]
\o/
And i'll be less noisy here now ;)

[1] https://nixos.org/nixos/manual/index.html#sec-nixos-tests

[timokau]

Reviewing this separately from #93450 to make it more manageable.

[timokau]

Is meta.repositories a standard? I've never seen it anywhere else.

[ardumont]

I don't know about a standard, but I have seen it within the nixpkgs repository [1]

(must come from the mediatomb which is within the list [1])

[1] https://github.com/NixOS/nixpkgs/search?q=meta.repositories

[ardumont]

After rebasing on latest upnp 1.4, it failed on compilation error, something
an include error on headers.
So I bump to a more recent version which happens since I updated this diff...
In its changelog is a reference about an include error fix (which is the one i got) [1]

[1] https://github.com/gerbera/gerbera/releases/tag/v1.6.1

It builds fine again now.

[timokau]

Setting to "changes requested" while waiting on #93048.

[timokau]

Looks good to me now, pending #93048 👍

[timokau]

Please rebase now that #93048 has been merged.

[timokau]

Thank you!