Skip to content

amule: 2.3.2 -> unstable-20201006#99893

Merged
timokau merged 1 commit intoNixOS:masterfrom
ardumont:bump-amule
Oct 7, 2020
Merged

amule: 2.3.2 -> unstable-20201006#99893
timokau merged 1 commit intoNixOS:masterfrom
ardumont:bump-amule

Conversation

@ardumont
Copy link
Contributor

@ardumont ardumont commented Oct 6, 2020

There has been no new release since 2.3.2 for some years now (around 2016) [1]

The most recent master branch for the amule project includes a commit [2] which
fixes compilation breakage with the next libupnp version [3].

So this bumps the amule version to the latest commit of that repository.

[1] amule-project/amule#219

[2] amule-project/amule@8784480

[3] #93048

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: nix on debian
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nixpkgs-review pr 99893 [2]
  • Tested execution of all binary files (usually in ./result/bin/) ~> amule starts and can connect to some kadmelia networks
  • Impact on package closure size: -58968 [1]
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1]

before: /nix/store/zsw4nifqvr7gl7is6ym0pmwdvyw969a9-amule-2.3.2   288470680
now: /nix/store/0kpzc5vi9vwn0y5w3ncpa5fr1jyv3mlm-amule-2.3.2      288529648

[2]

$ nixpkgs-review pr 99893
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/99893/head:refs/nixpkgs-review/1
From https://github.com/NixOS/nixpkgs
 + 98e5369bafa...1f7cf962918 refs/pull/99893/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/tony/.cache/nixpkgs-review/pr-99893/nixpkgs 9ae60c874749f2bdbfb1ffb1249621f050410ad7
Preparing worktree (detached HEAD 9ae60c87474)
Updating files: 100% (22850/22850), done.
HEAD is now at 9ae60c87474 act: build with go 1.15 on darwin
$ git merge --no-commit 1f7cf9629180506f6f651d835c9ed3e428b3811f
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/tony/.cache/nixpkgs-review/pr-99893/build.nix
building '/nix/store/7q7ic26fdaacnjsz8f06cwiydfjrxxrx-amule-unstable-20201006.drv'...
building '/nix/store/f20s02hml0hsw1pgyv08440akznw13x3-amule-unstable-20201006.drv'...
building '/nix/store/9xys7s31kyxkrc40kh718cl4v4m7mnkk-env.drv'...
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/99893
3 packages built:
amule amuleDaemon amuleGui

$ nix-shell /home/tony/.cache/nixpkgs-review/pr-99893/shell.nix

@ardumont ardumont mentioned this pull request Oct 6, 2020
10 tasks
@ofborg ofborg bot requested a review from Phreedom October 6, 2020 19:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 6, 2020
@ardumont ardumont changed the title amule: 2.3.2 -> 6f8951527eda670c7266984ce476061bfe8867fc amule: 2.3.2 -> unstable-20201006 Oct 6, 2020
There has been no new release since 2.3.2 for some years now (around 2016) [1]

The most recent master branch for the amule project includes a commit [2] which
fixes compilation breakage with the next libupnp version [3].

So this bumps the amule version to the latest commit of that repository.

[1] amule-project/amule#219

[2] amule-project/amule@8784480

[3] NixOS#93048
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 6, 2020
@timokau timokau merged commit 8722718 into NixOS:master Oct 7, 2020
@ardumont ardumont deleted the bump-amule branch October 7, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants