airwindows: init at unstable-2020-08-24 by magnetophon · Pull Request #89084 · NixOS/nixpkgs

magnetophon · 2020-05-28T06:35:44Z

Motivation for this change

Things done

OPNA2608

See review comments for some improvements.

OPNA2608 · 2020-05-28T08:13:25Z

pkgs/applications/audio/airwindows/default.nix

+{ stdenv, fetchFromGitHub, requireFile, unzip, cmake }:
+
+stdenv.mkDerivation rec {
+  name = "airwindows-${version}";


name is automatically constructed from pname-version.

Suggested change

name = "airwindows-${version}";

pname = "airwindows";

@OPNA2608 I seem to have messed up the push, sorry.
I'm working on getting the new fork to build, and once will than push the fixes.

I had some trouble pushing to this branch, so I made #123954

pkgs/applications/audio/airwindows/default.nix

OPNA2608 · 2020-05-28T08:43:18Z

pkgs/applications/audio/airwindows/default.nix

+      sha256 = "1ya4qbc63sb52nzisdapsydrnnpqnjsl5kgxibbr3dxf32474g89";
+    };
+    installPhase = "cp -r . $out";
+  };


You can add the unfree license here and keep the main derivation MIT.

Suggested change

};

meta.license = stdenv.lib.licenses.unfree;

};

Thanks for the feedback, I'm working on it.
I think you mean line 23, in vst-sdk, right?

Err yea, apologies.

pkgs/applications/audio/airwindows/default.nix

OPNA2608 · 2020-05-28T08:49:47Z

pkgs/applications/audio/airwindows/default.nix

+    sha256 = "1mh7c176fdl5y5ixkgzj2j2b7qifp3lgnxmbn6b7bvg3sv5wsxg3";
+  };
+
+  vst-sdk = stdenv.mkDerivation rec {


I see this duplicated over in the already existing airwave distribution, just in a different version.

nixpkgs/pkgs/applications/audio/airwave/default.nix

Lines 16 to 26 in 84cf00f

vst-sdk = stdenv.mkDerivation rec {

name = "vstsdk368_08_11_2017_build_121";

src = requireFile {

name = "${name}.zip";

url = "http://www.steinberg.net/en/company/developers.html";

sha256 = "e0f235d8826d70f1ae0ae5929cd198acae1ecff74612fde5c60cbfb45c2f4a70";

};

nativeBuildInputs = [ unzip ];

installPhase = "cp -r . $out";

meta.license = stdenv.lib.licenses.unfree;

};

And a PR with the SDK part updated to the very version you're requiring here, #82380

I think I'd rather see this as a separate derivation, but there were objections to that a long while ago (#10006). I wonder if these still exist? Just commenting on this situation, not requesting any change in particular.

magnetophon · 2020-05-28T11:25:37Z

I just found https://github.com/laserbat/airwindows, created a few hours ago.
I wonder if I should switch.
What do the creators think? @laserbat @ECH2

laserbat · 2020-06-03T23:58:29Z

Hi @magnetophon

I don't think it would b a good idea to switch, as my fork is for personal use and might not be 100% compatible with originals.

I can, however, make a branch that contains no changes other than improved build system for linux. Would that be helpful?

magnetophon · 2020-06-05T11:11:15Z

@laserbat Thanks for the feedback and the offer.
I don't know if it would be helpful.
I guess it depends on how up to date it is kept and how much it improves the build system.

laserbat · 2020-06-05T12:04:20Z

Well, current build system for linux doesn't really work without some patching and even with patches provided by some people in pull requests it has certain issues (mainly very slow build time). I rewrote the cmake setup so that's it's quick and painless to build and doesn't need any changes besides downloading VST SDK files.

Anyway, here's the branch in question https://github.com/laserbat/airwindows/tree/new_build

I do plan to keep it up to date. I'll set up a cron script that merges new changes from upstream into this branch, since upstream author only changes source files and not build configuration.

Hope this helps.

magnetophon · 2020-06-05T12:13:20Z

That sounds really good, thank you!
I'm finishing up some other stuff and then I'll base this package on your branch.

magnetophon · 2020-06-05T19:44:27Z

@laserbat
When I try to build that tree, I get:

-- Configuring done
CMake Error at CMakeLists.txt:19 (add_library):
  Cannot find source file:

    /tmp/nix-build-airwindows-2020-06-05.drv-0/source/plugins/LinuxVST/vstsdk/vstplugmain.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


CMake Error at CMakeLists.txt:26 (add_library):
  No SOURCES given to target: uLawEncode


CMake Error at CMakeLists.txt:26 (add_library):
  No SOURCES given to target: uLawDecode


CMake Error at CMakeLists.txt:26 (add_library):
  No SOURCES given to target: DeRez


CMake Error at CMakeLists.txt:26 (add_library):
  No SOURCES given to target: Golem

And then a whole lot more similar lines.
Any idea?

magnetophon · 2020-06-06T10:31:22Z

@laserbat I just noticed airwindows/airwindows@3c0d151
So it seems he does take external input, at least from you! ;)
Have you considered doing a PR with your build changes? (assuming the above error is a NixOS issue)

laserbat · 2020-06-09T19:53:49Z

@magnetophon unfortunately he is too busy to work on the build system right now. I offered him help, but he didn't seem to have the time.

And the build fails because you need to download VST SDK first, there's a script named get_vst_sdk.sh included in the LinuxVST folder.

Unfortunately Steinberg are really vigilant in DMCAing anybody who has this code in their repository, so it has to be downloaded every time before building.

magnetophon · 2020-06-10T01:51:42Z

@laserbat Thanks. I still can't get it to build though, sorry.

When I run the commands in that script and then build, I get:

CMake Error at CMakeLists.txt:12 (add_subdirectory):
  add_subdirectory given source "include/vstsdk" which is not an existing
  directory.


CMake Error at CMakeLists.txt:13 (add_airwindows_plugin):
  Unknown CMake command "add_airwindows_plugin".


-- Configuring incomplete, errors occurred!

When I change the commands to use "include/vstsdk" instead, I get:

CMake Error at CMakeLists.txt:12 (add_subdirectory):
  The source directory

    /tmp/nix-build-airwindows-unstable-2020-06-05.drv-0/source/plugins/LinuxVST/include/vstsdk

  does not contain a CMakeLists.txt file.


CMake Error at CMakeLists.txt:13 (add_airwindows_plugin):
  Unknown CMake command "add_airwindows_plugin".


-- Configuring incomplete, errors occurred!

laserbat · 2020-06-10T10:53:00Z

My bad! I fixed this issue

magnetophon · 2020-06-10T11:09:57Z

Ah, yes, now it builds. Thank you, I thought I was going crazy!
Any chance you will write an install target in the makefile?

magnetophon · 2020-06-10T12:36:14Z

@laserbat I installed manually, but Ardour has now blacklisted all of them.
How do I find out why?

SuperSandro2000 · 2021-02-08T23:56:29Z

pkgs/applications/audio/airwindows/default.nix

+    done;
+  '';
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-02-08T23:56:38Z

pkgs/applications/audio/airwindows/default.nix

+
+  nativeBuildInputs = [ cmake ];
+
+  patchPhase = ''


Suggested change

patchPhase = ''

postPatch = ''

I had some trouble pushing to this branch, so I made #123954

SuperSandro2000 · 2021-02-08T23:56:47Z

pkgs/applications/audio/airwindows/default.nix

+    cp -r ${airwindows-ports}/include/vstsdk/CMakeLists.txt include/vstsdk/
+    cp -r ${vst-sdk}/pluginterfaces include/vstsdk/pluginterfaces
+    cp -r ${vst-sdk}/public.sdk/source/vst2.x/* include/vstsdk/
+    chmod -R 777 include/vstsdk/pluginterfaces


Suggested change

chmod -R 777 include/vstsdk/pluginterfaces

chmod -R 755 include/vstsdk/pluginterfaces

OPNA2608 requested changes May 28, 2020

View reviewed changes

OPNA2608 reviewed May 28, 2020

View reviewed changes

magnetophon force-pushed the airwindows branch from 0bb4c8e to 993bb71 Compare May 28, 2020 10:28

magnetophon changed the title ~~airwindows: init at 2020-05-25~~ airwindows: init at unstable-2020-05-25 May 28, 2020

magnetophon force-pushed the airwindows branch from 993bb71 to e0dd479 Compare May 28, 2020 11:21

magnetophon force-pushed the airwindows branch from e0dd479 to 89cd7ea Compare May 30, 2020 12:10

magnetophon added 2 commits August 27, 2020 22:14

airwindows: init at 2020-05-25

e57c8fb

airwindows: unstable-2020-05-25 -> unstable-2020-08-24

e277c52

magnetophon force-pushed the airwindows branch from 3ead5c6 to e277c52 Compare August 27, 2020 20:15

magnetophon changed the title ~~airwindows: init at unstable-2020-05-25~~ airwindows: init at unstable-2020-08-24 Aug 27, 2020

SuperSandro2000 reviewed Feb 8, 2021

View reviewed changes

magnetophon closed this May 22, 2021

magnetophon mentioned this pull request May 22, 2021

airwindows: init at unstable-2022-01-29 #123954

Closed

9 tasks

	vst-sdk = stdenv.mkDerivation rec {
	name = "vstsdk368_08_11_2017_build_121";
	src = requireFile {
	name = "${name}.zip";
	url = "http://www.steinberg.net/en/company/developers.html";
	sha256 = "e0f235d8826d70f1ae0ae5929cd198acae1ecff74612fde5c60cbfb45c2f4a70";
	};
	nativeBuildInputs = [ unzip ];
	installPhase = "cp -r . $out";
	meta.license = stdenv.lib.licenses.unfree;
	};

	chmod -R 777 include/vstsdk/pluginterfaces
	chmod -R 755 include/vstsdk/pluginterfaces

Uh oh!

Conversation

magnetophon commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

OPNA2608 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magnetophon commented May 28, 2020

Uh oh!

laserbat commented Jun 3, 2020

Uh oh!

magnetophon commented Jun 5, 2020

Uh oh!

laserbat commented Jun 5, 2020

Uh oh!

magnetophon commented Jun 5, 2020

Uh oh!

magnetophon commented Jun 5, 2020

Uh oh!

magnetophon commented Jun 6, 2020

Uh oh!

laserbat commented Jun 9, 2020

Uh oh!

magnetophon commented Jun 10, 2020

Uh oh!

laserbat commented Jun 10, 2020

Uh oh!

magnetophon commented Jun 10, 2020

Uh oh!

magnetophon commented Jun 10, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

magnetophon commented May 28, 2020 •

edited

Loading