Skip to content

airwindows: init at unstable-2022-01-29#123954

Closed
magnetophon wants to merge 1 commit intoNixOS:masterfrom
magnetophon:airwindows2
Closed

airwindows: init at unstable-2022-01-29#123954
magnetophon wants to merge 1 commit intoNixOS:masterfrom
magnetophon:airwindows2

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented May 22, 2021 •
edited
Loading

Motivation for this change

Updated to latest commit on 2022-01-29

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon mentioned this pull request May 22, 2021
Closed
10 tasks
magnetophon
magnetophon commented May 22, 2021
View reviewed changes
pkgs/applications/audio/airwindows/default.nix Outdated
Copy link
Copy Markdown
Member Author

@magnetophon magnetophon May 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add license = lib.licenses.unfree; here, as suggested by @OPNA2608 I get:

error: cannot coerce a set to a string, at /home/bart/source/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:201:11

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 22, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented May 22, 2021 •
edited
Loading

Result of nixpkgs-review pr 123954 at e5cc29f3 run on aarch64-linux 1

1 package failed to build:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/audio/airwindows/default.nix:47:3:

       |
47 |   installPhase = ''
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 123954 at e5cc29f3 run on x86_64-linux 1

1 package failed to build:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/audio/airwindows/default.nix:47:3:

       |
47 |   installPhase = ''
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@stale
Copy link
Copy Markdown

stale bot commented Jan 9, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@magnetophon magnetophon closed this Jan 9, 2022
@magnetophon magnetophon reopened this Jan 9, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@magnetophon magnetophon changed the title airwindows: init at unstable-2021-05-07 airwindows: init at unstable-2021-12-24 Jan 9, 2022
@magnetophon magnetophon changed the title airwindows: init at unstable-2021-12-24 airwindows: init at unstable-2022-01-09 Jan 29, 2022
SuperSandro2000
SuperSandro2000 reviewed Jan 30, 2022
View reviewed changes
pkgs/applications/audio/airwindows/default.nix Outdated
Comment on lines 42 to 44
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symlinking those should be faster.

Copy link
Copy Markdown
Member Author

@magnetophon magnetophon Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wen I do ln -s instead of cp -r, I get chmod: cannot operate on dangling symlink 'include/vstsdk/pluginterfaces'.

pkgs/applications/audio/airwindows/default.nix Outdated
Comment on lines 26 to 35
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we copy everything to $out and do nothing else we can also only use fetchFromGitHub.

Copy link
Copy Markdown
Member Author

@magnetophon magnetophon Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand.
I thought you meant to remove the installPhase, but that errors out.

Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do something like https://github.com/NixOS/nixpkgs/blob/master/pkgs/data/fonts/fira/default.nix

pkgs/applications/audio/airwindows/default.nix Outdated
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "vstsdk366_27_06_2016_build_61";
pname = "vstsdk366";
version = "27_06_2016_build_61";

Copy link
Copy Markdown
Member Author

@magnetophon magnetophon Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ease the maintenance burden, I copied vst-sdk from oxefmsynth (also used like this in bespokesynth).

pkgs/applications/audio/airwindows/default.nix Outdated
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be meta.license.

Copy link
Copy Markdown
Member Author

@magnetophon magnetophon Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@magnetophon magnetophon changed the title airwindows: init at unstable-2022-01-09 airwindows: init at unstable-2022-01-29 Jan 30, 2022
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 30, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2022
@wegank wegank marked this pull request as draft March 20, 2024 15:29
@Sigmanificient
Copy link
Copy Markdown
Member

Sigmanificient commented Mar 17, 2025

It seems that airwindows was packaged with #371817

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 17, 2025
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Mar 18, 2025

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetophon @r-rmcgibbo @Sigmanificient @SuperSandro2000