Skip to content

gtk3: 3.24.18 → 3.24.20#86318

Merged
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:gtk-3.24.20
Apr 30, 2020
Merged

gtk3: 3.24.18 → 3.24.20#86318
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:gtk-3.24.20

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Apr 29, 2020

Motivation for this change

Fixes: #86287

Changes: https://gitlab.gnome.org/GNOME/gtk/blob/db39ce2b1699acaf5d0ba160cf7cc68ccf6e16d6/NEWS#L1-38

Also switch to a merged pkg-config patch and add a patch comment.

cc @hedning

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Apr 29, 2020
Closed
10 tasks
worldofpeace
worldofpeace reviewed Apr 29, 2020
View reviewed changes
@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

@ofborg eval

"Once more unto the breach!" (Might take a while to actually start since I've done this for a few other PRs in the past few minutes.)

@ofborg ofborg bot requested review from 7c6f434c, vcunat and worldofpeace April 29, 2020 18:31
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 29, 2020
@jtojnar jtojnar merged commit a60e61d into NixOS:staging Apr 30, 2020
@jtojnar jtojnar deleted the gtk-3.24.20 branch April 30, 2020 06:11
@prusnak prusnak mentioned this pull request May 2, 2020
Closed
@evils evils mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @cole-h @worldofpeace