Skip to content

gtk3: fix version number in pkg-config file#86287

Closed
vbgl wants to merge 1 commit intoNixOS:masterfrom
vbgl:gtk3-fix-pkg-config
Closed

gtk3: fix version number in pkg-config file#86287
vbgl wants to merge 1 commit intoNixOS:masterfrom
vbgl:gtk3-fix-pkg-config

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 29, 2020

Motivation for this change

Currently, pkg-config --modversion gtk+-3.0 reports “3.24.17” instead of the correct version number.

This PR fixes ocamlPackages.lablgtk3 and thus coq_8_10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 29, 2020

@GrahamcOfBorg build ocamlPackages.lablgtk3

@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

Will also allow #86217 to be built against master (currently, wxwidgets fails to build). Thank you!

@ofborg ofborg bot requested review from 7c6f434c and vcunat April 29, 2020 05:11
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 29, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 29, 2020

I have no idea why they don't have some CI automation for releases that bump the meson version. It would stop this from happening.

@jtojnar
Copy link
Member

jtojnar commented Apr 29, 2020

By the time they mark the tag, the damage is already done. They would need a the process to also handle the tagging for them.

Maybe we should just upgrade straight to 3.24.20:

https://gitlab.gnome.org/GNOME/gtk/-/blob/db39ce2b1699acaf5d0ba160cf7cc68ccf6e16d6/NEWS#L1-38

@prusnak
Copy link
Member

prusnak commented Apr 29, 2020

Maybe we should just upgrade straight to 3.24.20

ACK, seems reasonable

@vbgl
Copy link
Contributor Author

vbgl commented Apr 29, 2020

3.24.20 is more broken than 3.24.18: https://gitlab.gnome.org/GNOME/gtk/-/issues/2669

@jtojnar jtojnar mentioned this pull request Apr 29, 2020
Merged
10 tasks
@jtojnar
Copy link
Member

jtojnar commented Apr 29, 2020 •
edited
Loading

Updating GTK in #86318.

@vbgl vbgl closed this Apr 30, 2020
@vbgl vbgl deleted the gtk3-fix-pkg-config branch February 18, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

@vcunat vcunat Awaiting requested review from vcunat

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vbgl @cole-h @worldofpeace @jtojnar @prusnak