scala-runners: init at 0c0b369 by hrhino · Pull Request #84068 · NixOS/nixpkgs

hrhino · 2020-04-02T02:55:27Z

This is a script to run multiple versions of scala either by version number or build hash.

Motivation for this change

It's a good script and useful for testing with pre-release and non-current versions of Scala.

Things done

raboof

Tested on NixOS, compiling and running a Scala program on different versions indeed works.

raboof · 2020-08-30T10:15:11Z

maintainers/maintainer-list.nix

I think the convention is to put this into a separate commit titled maintainers: add hrhino (added #96666)

Done; thanks.

also pushed a newer version because, why not.

raboof · 2020-10-19T20:43:56Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

let

let

yikes. thanks.

SuperSandro2000 · 2020-11-27T09:16:38Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

let

name = "scala-runners";

owner = "dwijnand";

in stdenv.mkDerivation {

inherit name;

stdenv.mkDerivation rec {

name = "scala-runners";

Also, instead of having just a name, packages should nowadays have a pname and a version (#103997)

@raboof should I use (part of) the git tag? I can bother Dale if he wants to push tags but I think he may not care.

there's no clear consensus on how to version packages where upstream doesn't use tags (#100833), using the (short) git tag seems ok to me in this case.

@hrhino the convention I follow and I think is the best way to deal is

pname = "<name of software>"; version = "unstable-${date of the commit in the format YYYY-MM-DD}";

SuperSandro2000 · 2020-11-27T09:16:48Z

pkgs/development/compilers/scala-runners/default.nix

Please put meta at the end.

Done; thanks.

SuperSandro2000 · 2020-11-27T09:17:05Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

homepage = "https://github.com/${owner}/${name}";

homepage = "https://github.com/dwijnand/scala-runners";

Done; thanks.

SuperSandro2000 · 2020-11-27T09:17:13Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

maintainers = [ maintainers.hrhino ];

maintainers = with maintainers; [ hrhino ];

SuperSandro2000 · 2020-11-27T09:17:23Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

inherit owner;

owner = "dwijnand";

pkgs/development/compilers/scala-runners/default.nix

SuperSandro2000 · 2020-11-27T09:17:44Z

pkgs/development/compilers/scala-runners/default.nix

Suggested change

installPhase = ''

set -x

mkdir -p $out/bin $out/lib

sed -ie "s_\Wcs\W_ ${coursier}/bin/coursier _" scala-runner

cp scala-runner $out/lib

ln -s $out/lib/scala-runner $out/bin/scala

ln -s $out/lib/scala-runner $out/bin/scalac

ln -s $out/lib/scala-runner $out/bin/scalap

ln -s $out/lib/scala-runner $out/bin/scaladoc

'';

installPhase = ''

mkdir -p $out/bin $out/lib

sed -ie "s_\Wcs\W_ ${coursier}/bin/coursier _" scala-runner

cp scala-runner $out/lib

ln -s $out/lib/scala-runner $out/bin/scala

ln -s $out/lib/scala-runner $out/bin/scalac

ln -s $out/lib/scala-runner $out/bin/scalap

ln -s $out/lib/scala-runner $out/bin/scaladoc

'';

what changed here? just removing the set -x? I guess that's a good idea.

yeah. not sure why I selected more lines.

This is a script to run multiple versions of scala either by version number or build hash.

SuperSandro2000 · 2021-02-08T08:55:36Z

pkgs/development/compilers/scala-runners/default.nix

+let
+in stdenv.mkDerivation rec {


Suggested change

let

in stdenv.mkDerivation rec {

stdenv.mkDerivation rec {

SuperSandro2000 · 2021-02-08T08:56:27Z

pkgs/development/compilers/scala-runners/default.nix

+
+let
+in stdenv.mkDerivation rec {
+  name = "scala-runners";


Suggested change

name = "scala-runners";

pname = "scala-runners";

version = "unstable-2020-02-02"

SuperSandro2000 · 2021-02-08T08:57:36Z

pkgs/top-level/all-packages.nix


  scala = scala_2_13;
+  scala-runners = callPackage ../development/compilers/scala-runners/default.nix {
+    coursier = callPackage ../development/tools/coursier { jre = jdk8; };


Suggested change

coursier = callPackage ../development/tools/coursier { jre = jdk8; };

coursier = coursier.override { jre = jdk8; };

AndersonTorres · 2021-05-26T03:46:16Z

?

hrhino · 2021-06-25T00:35:12Z

#128060 to replace this because apparently force-push then reopen doesn't work. yay, github.

hrhino force-pushed the scala-runners branch from 28d3af0 to 28684f6 Compare April 7, 2020 01:31

puffnfresh approved these changes Apr 17, 2020

View reviewed changes

hrhino force-pushed the scala-runners branch from 28684f6 to 142c1f8 Compare June 4, 2020 01:27

raboof approved these changes Aug 30, 2020

View reviewed changes

hrhino force-pushed the scala-runners branch 2 times, most recently from 6022af9 to 975ba3f Compare September 13, 2020 18:26

hrhino changed the title ~~scala-runners: init at e6996f8~~ scala-runners: init at 0c0b369 Sep 13, 2020

raboof reviewed Oct 19, 2020

View reviewed changes

SuperSandro2000 requested changes Nov 27, 2020

View reviewed changes

SuperSandro2000 marked this pull request as draft December 27, 2020 23:56

maintainers: add hrhino

4b50012

hrhino force-pushed the scala-runners branch from 975ba3f to a9be6e4 Compare February 7, 2021 23:33

hrhino requested a review from SuperSandro2000 February 7, 2021 23:35

scala-runners: init at 95e03c9

1547fed

This is a script to run multiple versions of scala either by version number or build hash.

hrhino force-pushed the scala-runners branch from a9be6e4 to 1547fed Compare February 7, 2021 23:45

SuperSandro2000 requested changes Feb 8, 2021

View reviewed changes

raboof self-requested a review May 1, 2021 18:34

hrhino closed this May 26, 2021

hrhino mentioned this pull request Jun 25, 2021

scala-runners: init at unstable-2020-02-02 #128060

Merged

11 tasks

Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023

	homepage = "https://github.com/${owner}/${name}";
	homepage = "https://github.com/dwijnand/scala-runners";

	maintainers = [ maintainers.hrhino ];
	maintainers = with maintainers; [ hrhino ];

-  installPhase = ''
-    set -x
-    mkdir -p $out/bin $out/lib
-    sed -ie "s_\Wcs\W_ ${coursier}/bin/coursier _" scala-runner
-    cp scala-runner $out/lib
-    ln -s $out/lib/scala-runner $out/bin/scala
-    ln -s $out/lib/scala-runner $out/bin/scalac
-    ln -s $out/lib/scala-runner $out/bin/scalap
-    ln -s $out/lib/scala-runner $out/bin/scaladoc
-  '';
+  installPhase = ''
+    mkdir -p $out/bin $out/lib
+    sed -ie "s_\Wcs\W_ ${coursier}/bin/coursier _" scala-runner
+    cp scala-runner $out/lib
+    ln -s $out/lib/scala-runner $out/bin/scala
+    ln -s $out/lib/scala-runner $out/bin/scalac
+    ln -s $out/lib/scala-runner $out/bin/scalap
+    ln -s $out/lib/scala-runner $out/bin/scaladoc
+  '';

	name = "scala-runners";
	pname = "scala-runners";
	version = "unstable-2020-02-02"

	coursier = callPackage ../development/tools/coursier { jre = jdk8; };
	coursier = coursier.override { jre = jdk8; };

Uh oh!

Conversation

hrhino commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

raboof left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndersonTorres Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndersonTorres commented May 26, 2021

Uh oh!

hrhino commented Jun 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hrhino commented Apr 2, 2020 •

edited

Loading

AndersonTorres Feb 16, 2021 •

edited

Loading