Skip to content

scala-runners: init at unstable-2020-02-02#128060

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
hrhino:scala-runners
Jun 25, 2021
Merged

scala-runners: init at unstable-2020-02-02#128060
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
hrhino:scala-runners

Conversation

@hrhino
Copy link
Copy Markdown
Contributor

@hrhino hrhino commented Jun 25, 2021

Resubmission of #84068 (apparently you can't push changes and then reopen a PR on github?)

Motivation for this change

It's a good script and useful for testing with pre-release and non-current versions of Scala.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hrhino hrhino mentioned this pull request Jun 25, 2021
Closed
10 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 25, 2021
@Artturin
Copy link
Copy Markdown
Member

Artturin commented Jun 25, 2021

the title of the pr and commit should be scala-runners: init at unstable-2020-02-02

@hrhino hrhino changed the title scala-runners: init at 0c0b369 scala-runners: init at unstable-2020-02-02 Jun 25, 2021
@hrhino
Copy link
Copy Markdown
Contributor Author

hrhino commented Jun 25, 2021

As it now is. Thanks.

SuperSandro2000
SuperSandro2000 reviewed Jun 25, 2021
View reviewed changes
@hrhino
scala-runners: init at unstable-2020-02-02
246b757 
This is a script to run multiple versions of scala either by version
number or build hash.
@SuperSandro2000 SuperSandro2000 merged commit b9312e7 into NixOS:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hrhino @Artturin @SuperSandro2000