Skip to content

pythonPackages.qiskit-ignis: init at 0.2.0#83306

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-qiskit-ignis
Apr 1, 2020
Merged

pythonPackages.qiskit-ignis: init at 0.2.0#83306
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-qiskit-ignis

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 24, 2020

Motivation for this change

Update qiskit according to new upstream package structure (collection of subpackages). This is broken out of #78772.

Waiting on approval of #80662 , will rebase to remove the qiskit-aer commits when done.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2020
@drewrisinger drewrisinger mentioned this pull request Mar 26, 2020
Merged
10 tasks
@drewrisinger drewrisinger force-pushed the dr-pr-python-qiskit-ignis branch from 5d99331 to 8f4e17a Compare March 27, 2020 18:11
jonringer
jonringer reviewed Mar 27, 2020
View reviewed changes
@drewrisinger
pythonPackages.qiskit-ignis: init at 0.2.0
1f18c5a 
Qiskit Ignis is a toolbox for quantum hardware verification,
noise characterization, and error correction.

This commit follows the new Qiskit scheme of breaking one large package
into smaller packages (terra, aer, etc), and then having a single
meta-package "qiskit" that comprises them.
@drewrisinger drewrisinger force-pushed the dr-pr-python-qiskit-ignis branch from 8f4e17a to 1f18c5a Compare March 27, 2020 21:43
jonringer
jonringer approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83306 1

2 package built: - python37Packages.qiskit-ignis - python38Packages.qiskit-ignis

@drewrisinger drewrisinger deleted the dr-pr-python-qiskit-ignis branch April 6, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewrisinger @jonringer