tasty-tap: fix failing build#82906
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Mar 19, 2020
Merged
Conversation
- tasty-tap's tests were failing. In NixOS#71017 a patch generated from a PR was applied to fix this. - That PR has now been merged into tasty-tap and was released with version 0.1.0. - tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails to apply, breaking the build. - Removed the patch and removed tasty-tap from list of broken packages.
ofborg
bot
added
6.topic: haskell
Member
|
✌️ Compiles locally, so looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
tasty-tapwas failing to build because the changes in the patch it was trying to apply had already been released. Removed the patch and marked the package unbroken.See #71017 for the history.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)