Merged
Conversation
peti
requested changes
Oct 13, 2019
Member
peti
left a comment
peti
left a comment
There was a problem hiding this comment.
Please remove tasty-tap from the broken-packages section in configuration-hackage2nix.yaml, too. https://www.youtube.com/watch?v=KLhkAEk8I20 might be interesting to watch in that regard.
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
407ecc3 to
33366cc
Compare
ofborg
bot
added
6.topic: haskell
sevanspowell
force-pushed
the
feature/fix-tasty-tap-tests
branch
2 times, most recently
from
dfa9ad6 to
510f0e1
Compare
- The golden test for tasty-tap is out-of-date with the current TAP format. An issue has been submitted upstream here: MichaelXavier/tasty-tap#2. - I've created a pull request that makes the (minor) changes to the golden test file and applied the patch for that pull request here. - Remove tasty-tap from broken-packages
sevanspowell
force-pushed
the
feature/fix-tasty-tap-tests
branch
from
510f0e1 to
1e40b69
Compare
Contributor
Author
|
Sorry @peti, I watched that video but didn't pay enough attention. Done. |
ofborg
bot
added
10.rebuild-darwin: 0
peti
approved these changes
Oct 14, 2019
sevanspowell
added a commit
to sevanspowell/nixpkgs
that referenced
this pull request
Mar 19, 2020
- tasty-tap's tests were failing. In NixOS#71017 a patch generated from a PR was applied to fix this. - That PR has now been merged into tasty-tap and was released with version 0.1.0. - tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails to apply, breaking the build. - Removed the patch and removed tasty-tap from list of broken packages.
10 tasks
peti
pushed a commit
that referenced
this pull request
Mar 20, 2020
- tasty-tap's tests were failing. In #71017 a patch generated from a PR was applied to fix this. - That PR has now been merged into tasty-tap and was released with version 0.1.0. - tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails to apply, breaking the build. - Removed the patch and removed tasty-tap from list of broken packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti @basvandijk