Skip to content

libfido2: evaluate systemd only on Linux#80722

Merged
mmahut merged 1 commit intoNixOS:masterfrom
mmahut:libfido2
Feb 21, 2020
Merged

libfido2: evaluate systemd only on Linux#80722
mmahut merged 1 commit intoNixOS:masterfrom
mmahut:libfido2

Conversation

@mmahut
Copy link
Member

@mmahut mmahut commented Feb 21, 2020

Motivation for this change

After #80710, another take to on #80196.

I did not realize that the evaluation is done before the platform check.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 21, 2020
@mmahut mmahut merged commit 94fbb7b into NixOS:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant