Skip to content

libfido2: build only Linux#80710

Merged
mmahut merged 1 commit intoNixOS:masterfrom
mmahut:libfido2
Feb 21, 2020
Merged

libfido2: build only Linux#80710
mmahut merged 1 commit intoNixOS:masterfrom
mmahut:libfido2

Conversation

@mmahut
Copy link
Member

@mmahut mmahut commented Feb 21, 2020 •
edited
Loading

Motivation for this change

An attempt to fix the failed evaluation in #80196.

We should build libfido2 with systemd only on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 21, 2020
@mmahut mmahut changed the title libfido2: build with systemd only on linux libfido2: build only Linux Feb 21, 2020
@mmahut
Copy link
Member Author

mmahut commented Feb 21, 2020

No go anyway, libfido2 doesn't play well with darwin's libtool.

Filled a bug in Yubico/libfido2#127

Disabling darwin support for now.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 21, 2020
@ofborg ofborg bot requested a review from dtzWill February 21, 2020 12:10
lukateras
lukateras approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently nix-build -A libfido2 on x86_64-darwin fails with Package ‘systemd-242’ in pkgs/os-specific/linux/systemd/default.nix:220 is not supported on ‘x86_64-darwin’, refusing to evaluate, setting meta.platforms here makes its unsupported status transparent.

@mmahut mmahut merged commit 448c671 into NixOS:master Feb 21, 2020
@mmahut mmahut mentioned this pull request Feb 21, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

1 more reviewer

@lukateras lukateras lukateras approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmahut @lukateras