Skip to content

Additional redwax modules #76417

Merged
aanderse merged 1 commit intoNixOS:masterfrom
dirkx:redwax-modules
Jan 8, 2020
Merged

Additional redwax modules #76417
aanderse merged 1 commit intoNixOS:masterfrom
dirkx:redwax-modules

Conversation

@dirkx
Copy link
Contributor

@dirkx dirkx commented Dec 24, 2019

Submission of redwax modules to NixOS packages; including comments from review on #75620.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

Do you have a working configuration.nix snippet you used to test this code with that you could share?

@dirkx
Copy link
Contributor Author

dirkx commented Dec 24, 2019

Aanderse - still working on extracting that -- my test is currently tied in with some proprietary HSM code - which I am swapping for OpenSC/pcsclite.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2019
@dirkx
Copy link
Contributor Author

dirkx commented Dec 25, 2019

Ok - got a bunch of example files liberated and working in our end to end test.

E.g. for the time stamping: https://pastebin.com/GsSHj3DB

What is the proper way to add an example to a pull request ? Or make it part of the overal body of examples ?

@aanderse
Copy link
Member

@dirkx looking good 👍

I'm playing with your test example and will get back to you in the next couple days... but I think this is good to merge. Thanks for the work on this!

@aanderse
Copy link
Member

@dirkx I threw together a nixos test. Generally we don't make nixos tests for packages, just modules, unless there is a pressing need. Personally I think we should have tests for packages which do cool things like this one... 😎 but I'll leave that decision up to someone else. Take a look and see if my test makes sense based on your pastebin: master...aanderse:redwax

NOTE: There have been some changes to the httpd module since you created your PR so the configuration I have is a little bit off what you had.

@dirkx
Copy link
Contributor Author

dirkx commented Dec 30, 2019 via email

@dirkx
Copy link
Contributor Author

dirkx commented Dec 31, 2019

Slightly simplified and more realistic test at https://gist.github.com/dirkx/e4dc43ebcea0b3f372f5d6a3dce302e5.

Is it ok to use things like <(echo foo) in these scripts - or strictly bourne-shell neutral ?

@aanderse
Copy link
Member

aanderse commented Jan 1, 2020

@GrahamcOfBorg build mod_ca mod_crl mod_csr mod_ocsp mod_scep mod_pkcs12 mod_spkac mod_timestamp

@dirkx
Copy link
Contributor Author

dirkx commented Jan 1, 2020

@aanderse is there a way to kick off the tests `raw' without firing up the kvm/qemu isolation (as this is 90+ second affair from the docker containers that I use) ?

@dirkx dirkx closed this Jan 1, 2020
@dirkx dirkx reopened this Jan 1, 2020
@dirkx
Copy link
Contributor Author

dirkx commented Jan 1, 2020

Did not mean to close this. Slip of the mouse/finger.

@aanderse aanderse merged commit e9d3a3c into NixOS:master Jan 8, 2020
@aanderse
Copy link
Member

aanderse commented Jan 8, 2020

@dirkx thanks again for contributing this! I'm excited to see someone using apache httpd like this on NixOS.

@aanderse is there a way to kick off the tests `raw' without firing up the kvm/qemu isolation (as this is 90+ second affair from the docker containers that I use) ?

I think NixOS tests are tied to qemu, but I don't know all the details because I've never looked at the implementation. If you post questions like this on https://discourse.nixos.org/ you will get great answers... better than I can give you 😄

@dirkx
Copy link
Contributor Author

dirkx commented Jan 8, 2020

Ack - will do & will do a PR for the test/example use cases for the other modules too.

@dirkx dirkx deleted the redwax-modules branch January 8, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants