Skip to content

Remove mbedtls_1_3, alienfx, coprthr, firestr#75310

Merged
fpletz merged 4 commits intoNixOS:masterfrom
c0bw3b:rem/mbed13-alienfx-coprthr-firestr
Dec 9, 2019
Merged

Remove mbedtls_1_3, alienfx, coprthr, firestr#75310
fpletz merged 4 commits intoNixOS:masterfrom
c0bw3b:rem/mbed13-alienfx-coprthr-firestr

Conversation

@c0bw3b
Copy link
Copy Markdown
Contributor

@c0bw3b c0bw3b commented Dec 8, 2019

Motivation for this change
  • mbedtls_1_3 has been end of life for a while, we don't need it in nixpkgs anymore after Refresh LinPhone ecosystem #74043
    cc @fpletz

  • alienfx upstream doesn't exist anymore (reported by Repology)
    cc @tomberek

  • coprthr has been marked broken for ~5 years (and upstream released a new major version since)
    cc @thoughtpolice

  • firestr has been marked broken for ~4 years
    cc @ehmry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Upstream is gone
It's been marked as broken for 5 years
It's been marked as broken for 4 years
@c0bw3b c0bw3b added the 6.topic: hygiene Cleaning up and removing cruft label Dec 8, 2019
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 8, 2019
Copy link
Copy Markdown
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. I like the idea of cleaning up old/broken packages. I'll approve the alienfx portion.

@fpletz fpletz merged commit 8bad6c4 into NixOS:master Dec 9, 2019
@c0bw3b c0bw3b deleted the rem/mbed13-alienfx-coprthr-firestr branch December 9, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: hygiene Cleaning up and removing cruft 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants