Skip to content

Refresh LinPhone ecosystem#74043

Merged
7c6f434c merged 7 commits intoNixOS:masterfrom
c0bw3b:pkg/belledonne
Nov 24, 2019
Merged

Refresh LinPhone ecosystem#74043
7c6f434c merged 7 commits intoNixOS:masterfrom
c0bw3b:pkg/belledonne

Conversation

@c0bw3b
Copy link
Copy Markdown
Contributor

@c0bw3b c0bw3b commented Nov 24, 2019

Motivation for this change

Main goal is to cleanup the last dependencies on mbedtls_1_3 which has been EoL for a while now
+ mediastreamer-openh264 update
+ fix many homepages pointing to non-existing pages under the linphone.org domain
+ add bcg729 library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

Result of nix-review

12 package were build:
  • bcg729
  • bctoolbox
  • belcard
  • belle-sip
  • belr
  • bzrtp
  • linphone
  • mediastreamer
  • mediastreamer-openh264
  • msilbc
  • ortp
  • trx

@c0bw3b
bctoolbox: set meta.homepage
b1a24b2 
+ move cmake and bcunit to nativeBuildInputs

+ use current mbedtls
@c0bw3b
ortp: fix meta.homepage
fca07bf 
+ license is now GPL2+
@c0bw3b
belle-sip: fix meta.homepage
4b94f4b 
+ use pname/version
+ polarssl -> mbedtls
+ no need for configure flag to find mbedtls
@c0bw3b
mediastreamer2: fix meta.homepage
7247c2b 
+ remove openssl from inputs (it's not used)
+ fix git version CFLAGS
@c0bw3b
mediastreamer-openh264: 0.0pre20160801 -> 1.2.1
da38777
@c0bw3b
bcg729: init at 1.0.4
8933dd6
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 24, 2019
@ofborg ofborg bot requested a review from 7c6f434c November 24, 2019 14:30
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 24, 2019
@c0bw3b
linphone: polarssl -> mbedtls
9c4f512 
+ add bcg729 input
+ move bcunit to nativeBuildInputs
@ofborg ofborg bot requested a review from 7c6f434c November 24, 2019 19:04
7c6f434c
7c6f434c reviewed Nov 24, 2019
View reviewed changes
@7c6f434c 7c6f434c merged commit 5b39722 into NixOS:master Nov 24, 2019
@c0bw3b c0bw3b deleted the pkg/belledonne branch November 24, 2019 20:37
@c0bw3b c0bw3b mentioned this pull request Dec 1, 2019
Merged
10 tasks
@c0bw3b c0bw3b mentioned this pull request Dec 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c0bw3b @7c6f434c