Skip to content

elogind: 239.5 -> 241.3#73376

Merged
nh2 merged 1 commit intoNixOS:masterfrom
nh2:elogind-241.3
Nov 20, 2019
Merged

elogind: 239.5 -> 241.3#73376
nh2 merged 1 commit intoNixOS:masterfrom
nh2:elogind-241.3

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Nov 14, 2019

Motivation for this change

Changelog: https://github.com/elogind/elogind/releases/tag/v241.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

myself

@nh2
Copy link
Contributor Author

nh2 commented Nov 14, 2019

@GrahamcOfBorg build

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 14, 2019
@nh2
Copy link
Contributor Author

nh2 commented Nov 14, 2019

Why does ofborg say this rebuilds >= 11 packages on Darwin?

This even has platforms = platforms.linux.

@nh2
Copy link
Contributor Author

nh2 commented Nov 14, 2019

Why does ofborg say this rebuilds >= 11 packages on Darwin?

Uh looks like the dep is pulled in for polkit on Darwin. Probably want to make that optional.

My fault in commit 1ca49b8 / PR #72057.

@nh2 nh2 mentioned this pull request Nov 14, 2019
Merged
10 tasks
@nh2 nh2 merged commit b679ce8 into NixOS:master Nov 20, 2019
@nh2
Copy link
Contributor Author

nh2 commented Nov 20, 2019

My fault in commit 1ca49b8 / PR #72057.

Fixing in #73837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nh2