musl support for polkit, add elogind#72057
Conversation
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
Can we just escape " with \ here?
There was a problem hiding this comment.
Is that better?
I thought one purpose (as per nix manual) of '' quotes is to not have to do so much escaping.
There was a problem hiding this comment.
Is that in the nix manual? I just think it's weird to use when it isn't multi-line, perhaps it's just my style preference.
There was a problem hiding this comment.
I prefer to use English quotes and apostrophes (u+201c, u+201d, u+2019) in human readable texts, which bypasses the need for escaping altogether.
There was a problem hiding this comment.
Is that in the nix manual?
Yes here:
Indented strings are primarily useful in that they allow multi-line string literals to follow the indentation of the enclosing Nix expression, and that less escaping is typically necessary for strings representing languages such as shell scripts and configuration files because '' is much less common than ".
For what it's worth, I just copied the description verbatim from the Github repo description on https://github.com/elogind/elogind and using '' made it possible to do that without having to mess with the description.
nh2
force-pushed
the
polkit-musl-elogind
branch
2 times, most recently
from
8d5b2c7 to
6bd7015
Compare
|
I've extracted the mass-rebuliding patch stability commit into @GrahamcOfBorg eval |
ofborg
bot
added
10.rebuild-linux: 1-10
|
It does concern me that a lot of the things I maintain have musl support added which I now have to maintain. And I don't really know a thing about musl so I may end up breaking this regularly if you don't co-maintain this. Thoughts? |
|
@GrahamcOfBorg build pkgsMusl.elogind pkgsMusl.polkit polkit elogind |
nh2
force-pushed
the
polkit-musl-elogind
branch
from
6bd7015 to
1ca49b8
Compare
@worldofpeace I understand your concern. I'm happy to help co-maintain the musl parts. If you have some changes that need to go through that break musl support, that is also OK (given that it isn't currently expected to have top-tier support); you can ping me and I will fix the fallout. @matthewbauer, @Ericson2314 and @dtzWill are also interested in having good musl support because it makes our use cases of static binaries and cross compilation easier, so there will be multiple people around to help with musl-related things. For #43795 and https://github.com/nh2/static-haskell-nix I am building out CI that can notice when any of the musl stuff I use breaks, to make maintaining them in good state easier. I will also be working in the future to make ofborg and/or Hydra help with that. |
Ah ok, thank goodness actually 😄 That's precisely what I hoped was going on. From my purview it was a lot of changes going through and I wasn't involved in the discussion behind them, so I was a bit concerned. But it sounds perfectly reasonable. |
worldofpeace
left a comment
worldofpeace
left a comment
There was a problem hiding this comment.
I'm not sure if the base branch has the required commits for this to pass CI, but it's a LGTM.
I think it should have, it built fine for me locally. I'll have a look if I can do something short term that makes ofborg successfully build |
musl support for polkit, add elogind (cherry picked from commit 62fbcea)
|
I realised in #73376 (comment) this change added an We should |
Fixing in #73837. |
In NixOS#72057 I added support for elogind when systemd is not supported, but it occurred to me that it probably doens't make sense to have either of systemd or elogind on Darwin.
3 participants
Motivation for this change
Being able to build musl-based static applications, like for
static-haskell-nix, that depend onpolkit.systemddoes not build with musl; it depends on alogind, andelogindis one that explicitly supports musl.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
no maintainers in file!