nodePackages.typescript-language-server: add typescript dependency#73119
Closed
kira-bruneau wants to merge 1 commit intoNixOS:masterfrom
Closed
nodePackages.typescript-language-server: add typescript dependency#73119kira-bruneau wants to merge 1 commit intoNixOS:masterfrom
kira-bruneau wants to merge 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
This looks good to me! (Works on my macOS machine.) |
jD91mZM2
approved these changes
Dec 22, 2019
Member
jD91mZM2
left a comment
jD91mZM2
left a comment
There was a problem hiding this comment.
I stumbled upon this after wondering why typescript-language-server didn't work like it should. Adding typescript as an installed package worked too - although this is obviously a much better solution.
kira-bruneau
force-pushed
the
typescript-language-server
branch
from
b6eb9c8 to
1b5ebc9
Compare
Member
|
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
prusnak
added
2.status: merge conflict
typescript-language-server is a wrapper around tsserver and is useless without it
kira-bruneau
force-pushed
the
typescript-language-server
branch
from
1b5ebc9 to
d845152
Compare
Contributor
Author
|
@prusnak I just force pushed a change to bring it up-to-date. |
ofborg
bot
removed
the
2.status: merge conflict
prusnak
approved these changes
May 30, 2020
Member
|
Just wondering would a local tsserver installation still override the default one with these changes? |
Contributor
Author
|
@felschr No, right now it wouldn't. But I could update |
ryantm
added
2.status: merge conflict
Member
|
PR got combined with a few other node updates. Closing so that the update goes trough smoothly. |
10 tasks
jlesquembre
added a commit
to jlesquembre/nixpkgs
that referenced
this pull request
Jan 20, 2022
…back Make possible to use a different typescript version. If there is already a typescript binary on your PATH, probably you want to use that. This way it's possible to use a different typescript version (with nix shell, direnv, npm, ...), but still have a fallback version, so the lsp server doesn't fail to start Related to NixOS#73119
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
typescript-language-server is a wrapper around tsserver and is useless without it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @malob