nodePackages.typescript-language-server: typescript dependecy as fallback#155855
Merged
kira-bruneau merged 1 commit intoNixOS:masterfrom Jan 21, 2022
Merged
nodePackages.typescript-language-server: typescript dependecy as fallback#155855kira-bruneau merged 1 commit intoNixOS:masterfrom
kira-bruneau merged 1 commit intoNixOS:masterfrom
Conversation
…back Make possible to use a different typescript version. If there is already a typescript binary on your PATH, probably you want to use that. This way it's possible to use a different typescript version (with nix shell, direnv, npm, ...), but still have a fallback version, so the lsp server doesn't fail to start Related to NixOS#73119
ofborg
bot
added
10.rebuild-darwin: 0
SuperSandro2000
approved these changes
Jan 20, 2022
Contributor
|
This looks good to me! |
kira-bruneau
approved these changes
Jan 21, 2022
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make possible to use a different typescript version.
If there is already a typescript binary on your PATH, probably you want
to use that. This way it's possible to use a different typescript
version (with nix shell, direnv, npm, ...), but still have a fallback
version, so the lsp server doesn't fail to start
Related to #73119 and #108235
ping @kira-bruneau @SuperSandro2000
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes