Closed
Conversation
JohnAZoidberg
requested changes
Nov 7, 2019
Member
JohnAZoidberg
left a comment
There was a problem hiding this comment.
Cool! Works, tried to "grip" through nixpkgs.
pkgs/tools/text/gripgen/default.nix
Outdated
Member
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256:0bkqarylgzhis6fpj48qbifcd6a26cgnq8784hgnm707rq9kb0rx"; | |
| sha256 = "0bkqarylgzhis6fpj48qbifcd6a26cgnq8784hgnm707rq9kb0rx"; |
Contributor
Author
There was a problem hiding this comment.
Will do in a wee bit
pkgs/tools/text/gripgen/default.nix
Outdated
Member
There was a problem hiding this comment.
Suggested change
| pname = "gripgen"; | |
| pname = "grip"; |
gripgen is only the tool to generate the database. (Also change commit and all-packages.nix)
Contributor
Author
There was a problem hiding this comment.
Grip is already taken,
Its some gui app, that's why I used gripgen
Ideally, we should have all our pkgs namespaced,
`tools.text.grip
but that's another battle
Member
Member
Contributor
Author
|
@tex has the thing sorted, so I can close this one |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
grip (gripgen) was missing in nixpkgs,
http://sc0ty.pl/2016/12/grip-indexed-grep/
grip allows me to grep through a 120GB source codebase in less than 10 secs
Things done
sandboxinnix.confon non-NixOS linux)Tested compilation of all pkgs that depend on this change usingnix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)