grip-0.8: indexed grip

[tex]

Motivation for this change

New CLI application for indexed grepping. Fast. Useful. Can be cross-compiled for Windows.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[tex]

Is there a clean way to solve project names clash?

[aanderse]

Oh... I see what is going on... never realized there was a grip already. I feel like grip the gnome application has likely existed much longer than grip the search+indexing tool. I guess you should rename your app? 🤷‍♂️

ping @jtojnar as a gnome expert and all around great person 😄

[jtojnar]

I would suggest choosing grip-search or gripgen attribute for this package. Then remove the old abandoned package. And only rename this package after some cycles.

[tex]

It is not my application :) I just found it useful in my job. Named attribute to grip-search. Probably no need to remove existing grip - at most if anyone use both there will be clash in names (grip), but I do not think too many people will want to use grip-search and grip together.

[aanderse]

I'm sorry this I haven't got back to this until now. This dropped off my radar.

On top of the suggestions I have made you should probably rename the file from grip.nix to grip-search.nix so it matches the attribute name.

After you're done with the changes please squash all commits into a single commit with message grip-search: init at 0.8.

[tex]

@aanderse Hi, please see changes.

[tex]

Hi, is there anything else needed to to to get this merged?

[Azulinho]

@JohnAZoidberg happy to be left out,
My Cmake skills are not that great,I'd rather focus on stuff I know well.

[tex]

Yes I tested it on Windows. Crosscompiled on NixOS targeted Windows and run in Wine and native Windows10.

…

On November 12, 2019 10:26:50 PM GMT+01:00, Daniel Schaefer ***@***.***> wrote: JohnAZoidberg commented on this pull request. > + sha256 = "0bkqarylgzhis6fpj48qbifcd6a26cgnq8784hgnm707rq9kb0rx"; + }; + + nativeBuildInputs = [ pkgconfig cmake ]; + + buildInputs = [ boost ]; + + patchPhase = '' + sed -i -e 's/"CUSTOM-BUILD"/${version}/' src/general/config.h + ''; + + meta = with stdenv.lib; { + description = "Fast, indexed regexp search over large file trees"; + homepage = "https://github.com/sc0ty/grip"; + license = licenses.gpl3; + platforms = platforms.linux ++ platforms.windows; You tested it on Windows? I think we shouldn't exclude MacOS because it is very likely to work. We can exclude it, once somebody notices it doesn't work there. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #60182 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[tex]

I tested crosscompile when I first submitted this merge request, but trying it now (with updated nixpkgs) leads to:

[1] milan@nixos> nix-build '<nixpkgs>' -A pkgsCross.mingwW64.meson                                                   /etc/nixos/nixpkgs
warning: Nix search path entry '/etc/nixos/overlay' does not exist, ignoring
error: attribute 'targetPlatform' missing, at /etc/nixos/nixpkgs/pkgs/development/tools/build-managers/meson/default.nix:70:17
(use '--show-trace' to show detailed location information)

I submitted this as bug #73420

[tex]

I tested crosscompile when I first submitted this merge request, but trying it now (with updated nixpkgs) leads to:

[1] milan@nixos> nix-build '<nixpkgs>' -A pkgsCross.mingwW64.meson                                                   /etc/nixos/nixpkgs
warning: Nix search path entry '/etc/nixos/overlay' does not exist, ignoring
error: attribute 'targetPlatform' missing, at /etc/nixos/nixpkgs/pkgs/development/tools/build-managers/meson/default.nix:70:17
(use '--show-trace' to show detailed location information)

I submitted this as bug #73420

Funny, it works, I tried to cross compile grip (the gui application) which failed. grip-search works.
See originaly it was named grip (and original grip removed), then I renamed to grip-search :D

[JohnAZoidberg]

Works fine on NixOS and I'm happy with the derivation.

When I build it for Windows with: nix-build -A pkgsCross.mingwW64.grip-search, copy result/bin/* to Windows 10 and run it, this happens:

Did you perform other steps?

[tex]

Oh, I tested that crosscompilation when I first created this merge request.
This must be dependency created by #73195 . Fun thing is that I modified grip on master to remove dependency on multithreading and other C++11 things that the #73195 enabled in Nix when crosscompiling. Guess you need to install that missing library into system, it is not dll created by grip.

[tex]

Or is it problem of #73195 that it doesn't provide all in runtime required libraries in resulting output?

[Ericson2314]

@tex We have always lacked a sufficiently good automated mechanism for copying all of the required DLLs into the bin/ directory. But if you build nix-build '<nixpkgs>' -A pkgsCross.mingwW64.threadsCross you can get the DLL and copy it yourself.