Skip to content

conftest: Remove sumdb override now that #34866 is merged#71479

Merged
kalbasit merged 1 commit intoNixOS:masterfrom
c00w:conftest_fix
Oct 24, 2019
Merged

conftest: Remove sumdb override now that #34866 is merged#71479
kalbasit merged 1 commit intoNixOS:masterfrom
c00w:conftest_fix

Conversation

@c00w
Copy link
Contributor

@c00w c00w commented Oct 21, 2019

Motivation for this change

There was an override in place for conftest to disable the sumdb - with this change it is no longer needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from kalbasit and yurrriq October 21, 2019 01:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 21, 2019
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurrriq
Copy link
Member

yurrriq commented Oct 22, 2019

@GrahamcOfBorg build conftest

@kalbasit kalbasit merged commit 52c8d46 into NixOS:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants