Skip to content

trivial: nixos: doc: efficient comparisons#34866

Merged
vcunat merged 3 commits intoNixOS:masterfrom
oxij:os/doc/efficient-comparisons
Feb 12, 2018
Merged

trivial: nixos: doc: efficient comparisons#34866
vcunat merged 3 commits intoNixOS:masterfrom
oxij:os/doc/efficient-comparisons

Conversation

@oxij
Copy link
Member

@oxij oxij commented Feb 12, 2018

Motivation for this change

Me eating up all of the precious hydra memory and much of its time with a7d75ab of #33898. See that PR for discussion.

Things done

@oxij oxij requested review from edolstra and nbp as code owners February 12, 2018 00:53
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 12, 2018
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff seems to be without down-sides. I agree with

Lets merge this and then see if you still want an option to disable sorting.

@vcunat
Copy link
Member

vcunat commented Feb 12, 2018

Ah, splitString – reminds me the line from the documentation :-)

NOTE: this function is not performant and should never be used.

@vcunat vcunat merged commit b468f98 into NixOS:master Feb 12, 2018
vcunat added a commit that referenced this pull request Feb 12, 2018
This solves most of the performance regression from a7d75ab (#33898).
@oxij oxij deleted the os/doc/efficient-comparisons branch September 8, 2018 22:16
c00w added a commit to c00w/nixpkgs that referenced this pull request Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants