Skip to content

haskellPackages: unbreak cachix build#67914

Merged
infinisil merged 1 commit intoNixOS:haskell-updatesfrom
marsam:unbreak-cachix
Sep 3, 2019
Merged

haskellPackages: unbreak cachix build#67914
infinisil merged 1 commit intoNixOS:haskell-updatesfrom
marsam:unbreak-cachix

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested a review from basvandijk as a code owner September 2, 2019 02:32
@marsam
Copy link
Contributor Author

marsam commented Sep 2, 2019

@GrahamcOfBorg build cachix

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 2, 2019
cdepillabout
cdepillabout reviewed Sep 2, 2019
View reviewed changes
@cdepillabout
Copy link
Member

cdepillabout commented Sep 2, 2019

@marsam I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file. Could you remove your changes from this file?

(#67438 (comment))

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 2, 2019

I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file.

Can confirm. See #67772.

@marsam
Copy link
Contributor Author

marsam commented Sep 2, 2019

@cdepillabout, @rnhmjoj thanks for reviewing. I've addressed your comments.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 2, 2019
rnhmjoj
rnhmjoj approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried removing the broken attribute and it builds.

@cdepillabout
Copy link
Member

cdepillabout commented Sep 3, 2019

cc @peti @infinisil

@infinisil infinisil merged commit 107d78b into NixOS:haskell-updates Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsam @cdepillabout @rnhmjoj @infinisil