haskellPackages.bisc: unmark as broken#67772
Merged
peti merged 1 commit intoNixOS:haskell-updatesfrom Aug 30, 2019
Merged
Conversation
peti
requested changes
Aug 30, 2019
Member
peti
left a comment
There was a problem hiding this comment.
-
Don't edit
hackage-packages.nix. See the comment at the very top of the file. -
If you are certain that the package actually compiles, then remove it from the list of broken packages in
pkgs/development/haskell-modules/configuration-hackage2nix.yamland submit that change to thehaskell-updatesbranch.
Contributor
Author
|
Ah, I thought the broken attribute is determined at the generation of hackage-packages.nix and that it was ok to remove until the next one. Sorry.
Yes, it does: it broke on a recent update but then I fixed it. |
peti
approved these changes
Aug 30, 2019
Contributor
Author
|
Thank you. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
One of my little packages, seeing it broken breaks my heart.
Things done
nix path-info -Sbefore and after)Notify maintainers
cc @peti