Skip to content

prometheus-cups-exporter: This shouldn't be packaged#116491

Merged
mmahut merged 1 commit intoNixOS:masterfrom
ThoreKr:patch-1
Mar 17, 2021
Merged

prometheus-cups-exporter: This shouldn't be packaged#116491
mmahut merged 1 commit intoNixOS:masterfrom
ThoreKr:patch-1

Conversation

@ThoreKr
Copy link
Contributor

@ThoreKr ThoreKr commented Mar 16, 2021

This exporter is outdated, broken by design and simply shouldn't be packaged.

Motivation for this change

There is no point in having this garbage version as a package. For peace of mind I want it gone.

Things done

Deleted the according .nix file created in #67634

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ThoreKr ThoreKr changed the title cups-exporter: This shouldn't be packaged prometheus-cups-exporter: This shouldn't be packaged Mar 16, 2021
@cole-h
Copy link
Member

cole-h commented Mar 16, 2021

Some comments:

  1. You need to remove it from pkgs/top-level/all-packages.nix.
  2. You should add an alias to pkgs/top-level/aliases.nix stating why it was removed.
  3. If it were me, I'd reword the commit to be prometheus-cups-exporter: remove or ...: drop.

This exporter is outdated, broken by design and simply shouldn't be packaged.
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 16, 2021
@ThoreKr
Copy link
Contributor Author

ThoreKr commented Mar 16, 2021

@cole-h Thanks for the remarks, I fixed these points.

@cole-h cole-h requested a review from mmahut March 16, 2021 16:34
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@mmahut mmahut merged commit d3292f7 into NixOS:master Mar 17, 2021
@ThoreKr ThoreKr deleted the patch-1 branch March 17, 2021 16:02
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants