nixos/misc: Fix nixpkgs.config merge function#66450
Merged
infinisil merged 1 commit intoNixOS:masterfrom Aug 10, 2019
Merged
Conversation
Previously nested attrsets would override each other
bkchr
approved these changes
Aug 10, 2019
Contributor
bkchr
left a comment
There was a problem hiding this comment.
Can confirm that this works :)
Member
Author
|
Backported to 19.03 in 68dd778 as well |
Contributor
|
@infinisil Hiii, coming here from #456510... yours was the most recent to touch the merge function, is there some obvious reason we can't do |
Member
Author
|
Just a guess, but it could be that extendModules didn't exist back then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously nested attrsets would override each other
With this module:
Before it would evaluate to
Now it evaluates to
Fixes a problem #66448 tries to workaround