programs.browserpass: Do not touch nixpkgs.config

[bkchr]

If we set nixpkgs.config.firefox from within the script, it somehow
overrides settings that are done in a configuration.nix.

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @

[infinisil]

We can't just do that because then browserpass won't work anymore in firefox..

The problem is in the merge function of nixpkgs.config, which doesn't merge such assignments correctly..

nixpkgs/nixos/modules/misc/nixpkgs.nix

Lines 34 to 43 in 809b38a

	configType = mkOptionType {
	name = "nixpkgs-config";
	description = "nixpkgs config";
	check = x:
	let traceXIfNot = c:
	if c x then true
	else lib.traceSeqN 1 x false;
	in traceXIfNot isConfig;
	merge = args: fold (def: mergeConfig def.value) {};
	};

[bkchr]

Ahh ty @infinisil. I assumed something like that but couldn't find the corresponding source code. Currently I just set enableBrowserpass by myself in configuration.nix.
Looking at the code, I don't see the bug at the first glance, can you fix this?

[infinisil]

Yup, just did, see above PR

[bkchr]

Nice ty!